This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/jmeter.git
commit 8c47aaad89cf8e3cbd202973d07c7e5fcee948b5 Author: Felix Schumacher <[email protected]> AuthorDate: Sun Aug 25 21:41:23 2019 +0200 Move JLabel fields to method variables --- .../protocol/smtp/sampler/gui/SmtpPanel.java | 48 ++++++++-------------- 1 file changed, 16 insertions(+), 32 deletions(-) diff --git a/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java b/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java index 6381d2b..8178082 100644 --- a/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java +++ b/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java @@ -52,7 +52,7 @@ import org.apache.jmeter.util.JMeterUtils; */ public class SmtpPanel extends JPanel { - private static final long serialVersionUID = 1L; + private static final long serialVersionUID = 2L; // local vars private JTextField tfMailFrom; @@ -72,22 +72,6 @@ public class SmtpPanel extends JPanel { private JTextArea taMessage; private JCheckBox cbPlainBody; - private JLabel jlAddressFrom; - private JLabel jlAddressReplyTo; - private JLabel jlAddressTo; - private JLabel jlAddressToCC; - private JLabel jlAddressToBCC; - private JLabel jlMailServerPort; - private JLabel jlMailServerTimeout; - private JLabel jlMailServerConnectionTimeout; - private JLabel jlMailServer; - private JLabel jlAttachFile; - private JLabel jlDutPortStandard; - private JLabel jlPassword; - private JLabel jlSubject; - private JLabel jlUsername; - private JLabel jlMessage; - private JFileChooser attachmentFileChooser; private JFileChooser emlFileChooser; private JTextField tfAuthPassword; @@ -528,21 +512,21 @@ public class SmtpPanel extends JPanel { * Main method of class, builds all gui-components for SMTP-sampler. */ private void initComponents() { - jlAddressReplyTo = new JLabel(JMeterUtils.getResString("smtp_replyto")); // $NON-NLS-1$ - jlAddressFrom = new JLabel(JMeterUtils.getResString("smtp_from")); // $NON-NLS-1$ - jlAddressTo = new JLabel(JMeterUtils.getResString("smtp_to")); // $NON-NLS-1$ - jlAddressToCC = new JLabel(JMeterUtils.getResString("smtp_cc")); // $NON-NLS-1$ - jlAddressToBCC = new JLabel(JMeterUtils.getResString("smtp_bcc")); // $NON-NLS-1$ - jlMailServerPort = new JLabel(JMeterUtils.getResString("smtp_server_port")); // $NON-NLS-1$ - jlMailServer = new JLabel(JMeterUtils.getResString("smtp_server")); // $NON-NLS-1$ - jlMailServerTimeout = new JLabel(JMeterUtils.getResString("smtp_server_timeout")); // $NON-NLS-1$ - jlMailServerConnectionTimeout = new JLabel(JMeterUtils.getResString("smtp_server_connection_timeout")); // $NON-NLS-1$ - jlAttachFile = new JLabel(JMeterUtils.getResString("smtp_attach_file")); // $NON-NLS-1$ - jlDutPortStandard = new JLabel(JMeterUtils.getResString("smtp_default_port")); // $NON-NLS-1$ - jlUsername = new JLabel(JMeterUtils.getResString("smtp_username")); // $NON-NLS-1$ - jlPassword = new JLabel(JMeterUtils.getResString("smtp_password")); // $NON-NLS-1$ - jlSubject = new JLabel(JMeterUtils.getResString("smtp_subject")); // $NON-NLS-1$ - jlMessage = new JLabel(JMeterUtils.getResString("smtp_message")); // $NON-NLS-1$ + JLabel jlAddressReplyTo = new JLabel(JMeterUtils.getResString("smtp_replyto")); // $NON-NLS-1$ + JLabel jlAddressFrom = new JLabel(JMeterUtils.getResString("smtp_from")); // $NON-NLS-1$ + JLabel jlAddressTo = new JLabel(JMeterUtils.getResString("smtp_to")); // $NON-NLS-1$ + JLabel jlAddressToCC = new JLabel(JMeterUtils.getResString("smtp_cc")); // $NON-NLS-1$ + JLabel jlAddressToBCC = new JLabel(JMeterUtils.getResString("smtp_bcc")); // $NON-NLS-1$ + JLabel jlMailServerPort = new JLabel(JMeterUtils.getResString("smtp_server_port")); // $NON-NLS-1$ + JLabel jlMailServer = new JLabel(JMeterUtils.getResString("smtp_server")); // $NON-NLS-1$ + JLabel jlMailServerTimeout = new JLabel(JMeterUtils.getResString("smtp_server_timeout")); // $NON-NLS-1$ + JLabel jlMailServerConnectionTimeout = new JLabel(JMeterUtils.getResString("smtp_server_connection_timeout")); // $NON-NLS-1$ + JLabel jlAttachFile = new JLabel(JMeterUtils.getResString("smtp_attach_file")); // $NON-NLS-1$ + JLabel jlDutPortStandard = new JLabel(JMeterUtils.getResString("smtp_default_port")); // $NON-NLS-1$ + JLabel jlUsername = new JLabel(JMeterUtils.getResString("smtp_username")); // $NON-NLS-1$ + JLabel jlPassword = new JLabel(JMeterUtils.getResString("smtp_password")); // $NON-NLS-1$ + JLabel jlSubject = new JLabel(JMeterUtils.getResString("smtp_subject")); // $NON-NLS-1$ + JLabel jlMessage = new JLabel(JMeterUtils.getResString("smtp_message")); // $NON-NLS-1$ tfMailServer = new JTextField(30); tfMailServerPort = new JTextField(6);
