This is an automated email from the ASF dual-hosted git repository.

pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 1d4d59c  Correcting client.rmi.localport port allocation description 
in remote
1d4d59c is described below

commit 1d4d59c703ace9a426c5808cecf29bdba245442f
Author: pmouawad <[email protected]>
AuthorDate: Sun Feb 16 14:40:05 2020 +0100

    Correcting client.rmi.localport port allocation description in remote
    
    This resolves #552
---
 xdocs/changes.xml                         |  2 ++
 xdocs/usermanual/properties_reference.xml |  6 ++++--
 xdocs/usermanual/remote-test.xml          | 18 ++++++++----------
 3 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/xdocs/changes.xml b/xdocs/changes.xml
index 2a80d41..8891394 100644
--- a/xdocs/changes.xml
+++ b/xdocs/changes.xml
@@ -173,6 +173,7 @@ to view the last release notes of version 5.2.1.
   <li><pr>547</pr>Correct Log level documentation. Contributed by 
jmetertea</li>
   <li><pr>548</pr>Correct typos in documentation. Contributed by jmetertea</li>
   <li><bug>64022</bug>Correct Chinese translation for "Ignore Sub-Controller 
blocks". Provided by yangxiaofei77 (yangxiaofei77 at gmail.com)</li>
+  <li><pr>552</pr>Fix <code>client.rmi.localport</code> port allocation 
description</li>
 </ul>
 
 <h3>General</h3>
@@ -192,6 +193,7 @@ to view the last release notes of version 5.2.1.
   <li>ray7219</li>
   <li>Sebastian Boga (sebastian.boga at endava.com)</li>
   <li>Liu XP (liu_xp2003 at sina.com)</li>
+  <li>anant-93 (https://github.com/anant-93)</li>
 </ul>
 <p>We also thank bug reporters who helped us improve JMeter.</p>
 <ul>
diff --git a/xdocs/usermanual/properties_reference.xml 
b/xdocs/usermanual/properties_reference.xml
index 79d4a8e..bd74dd9 100644
--- a/xdocs/usermanual/properties_reference.xml
+++ b/xdocs/usermanual/properties_reference.xml
@@ -333,8 +333,10 @@ JMETER-SERVER</source>
 </property>
 <property name="client.rmi.localport">
     Parameter that controls the RMI port used by the 
<code>RemoteSampleListenerImpl</code> (The Controller)<br/>
-    Default value is <code>0</code>, which means port is randomly assigned.
-    <note>You may need to open a port in the firewall on the Controller 
machine.</note>
+    Default value is <code>0</code>, which means port is randomly assigned. 
+    If this is non-zero, it will be used as the base for local port numbers 
for the client engine. 
+    At the moment JMeter will open up to three ports beginning with the port 
defined in this property. 
+    <note>You may need to open corresponding ports in the firewall on the 
Controller machine.</note>
     Defaults to: <code>0</code>
 </property>
 <property name="client.tries">
diff --git a/xdocs/usermanual/remote-test.xml b/xdocs/usermanual/remote-test.xml
index 9d81f22..81cb29f 100644
--- a/xdocs/usermanual/remote-test.xml
+++ b/xdocs/usermanual/remote-test.xml
@@ -87,15 +87,11 @@ Alternatively use different content in any datafiles used 
by the test
 <p>To run JMeter in remote node, start the JMeter server component on all 
machines you wish to run on by running
 the <code>JMETER_HOME/bin/jmeter-server</code> (unix) or 
<code>JMETER_HOME/bin/jmeter-server.bat</code> (windows) script.</p>
 <p>Note that there can only be one JMeter server on each node unless different 
RMI ports are used.</p>
-<p>Since JMeter 2.3.1, the JMeter server application starts the RMI registry 
itself;
-there is no need to start RMI registry separately.
-To revert to the previous behaviour, define the JMeter property 
<source>server.rmi.create=false</source> on the server host systems.
-</p>
+<p>The JMeter server application starts the RMI registry itself; there is no 
need to start RMI registry separately.</p>
 <p>
-By default, RMI uses dynamic ports for the JMeter server engine. This can 
cause problems for firewalls,
-so you can define the JMeter property <code>server.rmi.localport</code>
-to control this port numbers.
-If this is non-zero, it will be used as the base for local port numbers for 
the server engine. At the moment JMeter will open up to three ports beginning 
with the port defined in <code>server.rmi.localport</code>.
+By default, RMI uses a dynamic port for the JMeter server engine. This can 
cause problems for firewalls,
+so you can define the JMeter property <code>server.rmi.localport</code> to 
control this port number.
+it will be used as the local port number for the server engine.
 </p>
 <p><b>Step 2: Add the server IP to your client's Properties File</b></p>
 <p>Edit the properties file <i>on the controlling JMeter machine</i>.  In 
<code>JMETER_HOME/bin/jmeter.properties</code>,
@@ -201,8 +197,10 @@ Use the "<code>-s</code>" option with the jmeter startup 
script ("<code>jmeter -
 <p>
 JMeter/RMI requires a connection from the client to the server. This will use 
the port you chose, default <code>1099</code>.<br/>
 JMeter/RMI also requires a reverse connection in order to return sample 
results from the server to the client.<br/>
-This will use a high-numbered port. <br/>
-This port can be controlled by jmeter property called 
<code>client.rmi.localport</code> in <code>jmeter.properties</code>.<br/>
+These will use high-numbered ports. <br/>
+These ports can be controlled by jmeter property called 
<code>client.rmi.localport</code> in <code>jmeter.properties</code>.<br/>
+If this is non-zero, it will be used as the base for local port numbers for 
the client engine. At the moment JMeter will open
+up to three ports beginning with the port defined in 
<code>client.rmi.localport</code>.
 If there are any firewalls or other network filters between JMeter client and 
server,
 you will need to make sure that they are set up to allow the connections 
through.
 If necessary, use monitoring software to show what traffic is being generated.

Reply via email to