[jmeter] branch master updated: Remove public modifiers from JUnit5 tests

[fschumacher]

This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 4f9e9bc8b6 Remove public modifiers from JUnit5 tests
4f9e9bc8b6 is described below

commit 4f9e9bc8b6f1cdea7cbaeeebefdda7cae8182fd5
Author: Felix Schumacher <felix.schumac...@internetallee.de>
AuthorDate: Mon May 1 18:08:16 2023 +0200

    Remove public modifiers from JUnit5 tests
---
 .../apache/jmeter/config/gui/TestArgumentsPanel.java   |  6 +++---
 .../protocol/http/visualizers/RequestViewHTTPTest.java | 18 +++++++++---------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git 
a/src/components/src/test/java/org/apache/jmeter/config/gui/TestArgumentsPanel.java
 
b/src/components/src/test/java/org/apache/jmeter/config/gui/TestArgumentsPanel.java
index 47d5dd923b..19bf917363 100644
--- 
a/src/components/src/test/java/org/apache/jmeter/config/gui/TestArgumentsPanel.java
+++ 
b/src/components/src/test/java/org/apache/jmeter/config/gui/TestArgumentsPanel.java
@@ -30,14 +30,14 @@ import org.junit.jupiter.params.provider.CsvSource;
  * arguments (or parameters) are usually used to provide configuration values
  * for some other component.
  */
-public class TestArgumentsPanel {
+class TestArgumentsPanel {
 
     /**
      * Test that adding an argument to the table results in an appropriate
      * TestElement being created.
      */
     @Test
-    public void testArgumentCreation() throws Exception {
+    void testArgumentCreation() throws Exception {
         ArgumentsPanel gui = new ArgumentsPanel();
         gui.tableModel.addRow(new Argument());
         gui.tableModel.setValueAt("howdy", 0, 0);
@@ -56,7 +56,7 @@ public class TestArgumentsPanel {
             "WITH_SUFFIX_SPACE ,WITH_SUFFIX_SPACE",
             " WITH_PREFIX_SPACE,WITH_PREFIX_SPACE"
     }, ignoreLeadingAndTrailingWhitespace = false)
-    public void testArgumentNames(String name, String expectedName) throws 
Exception {
+    void testArgumentNames(String name, String expectedName) throws Exception {
         ArgumentsPanel gui = new ArgumentsPanel();
         gui.tableModel.addRow(new Argument());
         gui.tableModel.setValueAt(name, 0, 0);
diff --git 
a/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTPTest.java
 
b/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTPTest.java
index 974c992498..4fcb3dd462 100644
--- 
a/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTPTest.java
+++ 
b/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTPTest.java
@@ -33,10 +33,10 @@ import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 
-public class RequestViewHTTPTest {
+class RequestViewHTTPTest {
 
     @Test
-    public void testGetQueryMapValueContainingAmpersand() {
+    void testGetQueryMapValueContainingAmpersand() {
         // see https://bz.apache.org/bugzilla/show_bug.cgi?id=58413
         String query = "login=toto1&pwd=Welcome%261";
         Map<String, String[]> params = RequestViewHTTP.getQueryMap(query);
@@ -57,7 +57,7 @@ public class RequestViewHTTPTest {
 
     //http://www.foo.com/test/json/getXXXX.jsp?postalCode=59115&qrcode=
     @Test
-    public void testGetQueryMapWithEmptyValue() {
+    void testGetQueryMapWithEmptyValue() {
         String query = "postalCode=59115&qrcode=";
         Map<String, String[]> params = RequestViewHTTP.getQueryMap(query);
 
@@ -76,7 +76,7 @@ public class RequestViewHTTPTest {
     }
 
     @Test
-    public void testGetQueryMapMultipleValues() {
+    void testGetQueryMapMultipleValues() {
         String query = "param2=15&param1=12&param2=baulpismuth";
         Map<String, String[]> params = RequestViewHTTP.getQueryMap(query);
 
@@ -96,7 +96,7 @@ public class RequestViewHTTPTest {
     }
 
     @Test
-    public void testGetQueryMapAmpInValue() {
+    void testGetQueryMapAmpInValue() {
         String query = "param2=15&param1=12&param3=baul%26Pismuth";
         Map<String, String[]> params = RequestViewHTTP.getQueryMap(query);
 
@@ -120,7 +120,7 @@ public class RequestViewHTTPTest {
     }
 
     @Test
-    public void testGetQueryMapBug54055() {
+    void testGetQueryMapBug54055() {
         String query = 
"param2=15&param1=12&param3=bu4m1KzFvsozCnR4lra0%2Be69YzpnRcF09nDjc3VJvl8%3D";
         Map<String, String[]> params = RequestViewHTTP.getQueryMap(query);
 
@@ -144,7 +144,7 @@ public class RequestViewHTTPTest {
     }
 
     @Test
-    public void testGetQueryMapBug52491() {
+    void testGetQueryMapBug52491() {
         String query = 
"<envelope><header><context><conversationId>119</conversationId></context></header>"
                 + "<body><call component=\"OrderTransfer\" 
method=\"getSourceManifestID\" id=\"2\">\n"
                 + "<params></params><refs></refs></call></body></envelope>";
@@ -161,7 +161,7 @@ public class RequestViewHTTPTest {
     }
 
     @Test
-    public void testGetQueryMapSoapHack() {
+    void testGetQueryMapSoapHack() {
         String query = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
                 + "<SOAP-ENV:Envelope 
xmlns:SOAP-ENV=\"http://schemas.xmlsoap.org/soap/envelope/\"\n"; +
                 
"xmlns:SOAP-ENC=\"http://schemas.xmlsoap.org/soap/encoding/\"\n"; +
@@ -229,7 +229,7 @@ public class RequestViewHTTPTest {
 
     @ParameterizedTest
     @MethodSource("data")
-    public void testGetQueryMapWithEmptyKeyAndValue(String query, Map<String, 
List<String>> expected) {
+    void testGetQueryMapWithEmptyKeyAndValue(String query, Map<String, 
List<String>> expected) {
         Map<String, String[]> params = RequestViewHTTP.getQueryMap(query);
         Assertions.assertNotNull(params);
         Assertions.assertEquals(expected.size(), params.size());