This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git

commit 939ae3c0461fd45c642c9d7bc3ffb5b4a7b41bb9
Author: Felix Schumacher <[email protected]>
AuthorDate: Fri Oct 4 16:26:09 2024 +0200

    Ensure directories are writable when generating reports from read-only 
sources
---
 .../main/java/org/apache/jmeter/report/dashboard/TemplateVisitor.java  | 3 +++
 xdocs/changes.xml                                                      | 1 +
 2 files changed, 4 insertions(+)

diff --git 
a/src/core/src/main/java/org/apache/jmeter/report/dashboard/TemplateVisitor.java
 
b/src/core/src/main/java/org/apache/jmeter/report/dashboard/TemplateVisitor.java
index c4bdc15f8f..1e8fa7a966 100644
--- 
a/src/core/src/main/java/org/apache/jmeter/report/dashboard/TemplateVisitor.java
+++ 
b/src/core/src/main/java/org/apache/jmeter/report/dashboard/TemplateVisitor.java
@@ -93,6 +93,9 @@ public class TemplateVisitor extends SimpleFileVisitor<Path> {
                             "{}, found non empty folder with following content 
{}, will be ignored",
                     file, newDir, ex.getMessage(), 
newDir.toFile().listFiles());
         }
+        if (!newDir.toFile().canWrite()) {
+            newDir.toFile().setWritable(true);
+        }
         return FileVisitResult.CONTINUE;
     }
 
diff --git a/xdocs/changes.xml b/xdocs/changes.xml
index 025af48bca..b3c79ec82e 100644
--- a/xdocs/changes.xml
+++ b/xdocs/changes.xml
@@ -67,6 +67,7 @@ Summary
     <li><pr>6274</pr> Change references to old MySQL driver to new class 
<code>com.mysql.cj.jdbc.Driver</code></li>
     <li><issue>6352</issue> Calculate delays in Open Model Thread Group and 
Precise Throughput
         Timer relative to start of Thread Group instead of the start of the 
test.</li>
+    <li><issue>6357</issue> Ensure writable directories when copying template 
files while report generation.</li>
   </ul>
 
  <!--  =================== Thanks =================== -->

Reply via email to