This is an automated email from the ASF dual-hosted git repository.
vladimirsitnikov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git
The following commit(s) were added to refs/heads/master by this push:
new 577b7b60cf chore: run Errorprone verifications by default
577b7b60cf is described below
commit 577b7b60cfe90608cca34cb0f89404271f507aac
Author: Vladimir Sitnikov <[email protected]>
AuthorDate: Fri Jul 18 16:28:31 2025 +0300
chore: run Errorprone verifications by default
---
.github/workflows/main.yml | 4 +++-
build-logic/build-parameters/build.gradle.kts | 3 +--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 92a22d3157..6e2a80aae6 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -80,6 +80,8 @@ jobs:
jdkBuildVersion=17
jdkTestVersion=${{ matrix.java_version }}
jdkTestVendor=${{ matrix.java_vendor }}
+ # We have a separate job with Errorprone verifications, so avoid
duplicate warnings
+ enableErrorprone=false
# We provision JDKs with GitHub Actions for caching purposes, so
Gradle should rather fail in case JDK is not found
org.gradle.java.installations.auto-download=false
env:
@@ -101,6 +103,6 @@ jobs:
with:
job-id: errprone
multi-cache-enabled: false
- arguments: --scan --no-parallel --no-daemon -PenableErrorprone classes
+ arguments: --scan --no-parallel --no-daemon classes
env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
diff --git a/build-logic/build-parameters/build.gradle.kts
b/build-logic/build-parameters/build.gradle.kts
index 9af59d0bc2..7172aba71d 100644
--- a/build-logic/build-parameters/build.gradle.kts
+++ b/build-logic/build-parameters/build.gradle.kts
@@ -99,8 +99,7 @@ buildParameters {
description.set("Skip suppressPomMetadataWarningsFor warnings
triggered by inability to map test fixtures dependences to Maven pom.xml")
}
bool("enableErrorprone") {
- // By default, disable errorProne in CI so we don't perform the same
checks in several jobs
- defaultValue.set(System.getenv("CI") != "true")
+ defaultValue.set(true)
description.set("Enable ErrorProne verifications")
}
bool("skipJavadoc") {
