Author: juanpablo
Date: Thu Dec 26 19:56:08 2013
New Revision: 1553566
URL: http://svn.apache.org/r1553566
Log:
avoiding printStackTrace, redirecting to log
Modified:
jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java
jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/management/SimpleMBean.java
Modified:
jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java
URL:
http://svn.apache.org/viewvc/jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java?rev=1553566&r1=1553565&r2=1553566&view=diff
==============================================================================
--- jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java
(original)
+++ jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java Thu
Dec 26 19:56:08 2013
@@ -632,32 +632,27 @@ public class WikiEngine
{
// RuntimeExceptions may occur here, even if they shouldn't.
log.fatal( "Failed to start managers.", e );
- e.printStackTrace();
throw new WikiException( "Failed to start managers:
"+e.getMessage(), e );
}
catch (ClassNotFoundException e)
{
log.fatal( "JSPWiki could not start, URLConstructor was not found:
",e );
- e.printStackTrace();
throw new WikiException(e.getMessage(), e );
}
catch (InstantiationException e)
{
log.fatal( "JSPWiki could not start, URLConstructor could not be
instantiated: ",e );
- e.printStackTrace();
throw new WikiException(e.getMessage(), e );
}
catch (IllegalAccessException e)
{
log.fatal( "JSPWiki could not start, URLConstructor cannot be
accessed: ",e );
- e.printStackTrace();
throw new WikiException(e.getMessage(), e );
}
catch( Exception e )
{
// Final catch-all for everything
log.fatal( "JSPWiki could not start, due to an unknown exception
when starting.",e );
- e.printStackTrace();
throw new WikiException("Failed to start; please check log files
for better information.", e );
}
Modified:
jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/management/SimpleMBean.java
URL:
http://svn.apache.org/viewvc/jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/management/SimpleMBean.java?rev=1553566&r1=1553565&r2=1553566&view=diff
==============================================================================
---
jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/management/SimpleMBean.java
(original)
+++
jspwiki/trunk/jspwiki-war/src/main/java/org/apache/wiki/management/SimpleMBean.java
Thu Dec 26 19:56:08 2013
@@ -22,9 +22,23 @@ import java.lang.reflect.InvocationTarge
import java.lang.reflect.Method;
import java.util.Iterator;
-import javax.management.*;
+import javax.management.Attribute;
+import javax.management.AttributeList;
+import javax.management.AttributeNotFoundException;
+import javax.management.DynamicMBean;
+import javax.management.IntrospectionException;
+import javax.management.InvalidAttributeValueException;
+import javax.management.MBeanAttributeInfo;
+import javax.management.MBeanConstructorInfo;
+import javax.management.MBeanException;
+import javax.management.MBeanInfo;
+import javax.management.MBeanNotificationInfo;
+import javax.management.MBeanOperationInfo;
+import javax.management.NotCompliantMBeanException;
+import javax.management.ReflectionException;
import org.apache.commons.lang.StringUtils;
+import org.apache.log4j.Logger;
/**
* A simple MBean which does not require an interface class unlike
@@ -40,9 +54,9 @@ import org.apache.commons.lang.StringUti
*/
// FIXME: This class should really use Annotations instead of a method call.
// FIXME: Exception handling is not probably according to spec...
-public abstract class SimpleMBean
- implements DynamicMBean
-{
+public abstract class SimpleMBean implements DynamicMBean {
+
+ private static final Logger LOG = Logger.getLogger( SimpleMBean.class );
protected MBeanInfo m_beanInfo;
private static Method findGetterSetter( Class<?> clazz, String name,
Class<?> parm )
@@ -208,22 +222,22 @@ public abstract class SimpleMBean
catch (SecurityException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (IllegalArgumentException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (IllegalAccessException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (InvocationTargetException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
return res;
@@ -248,17 +262,17 @@ public abstract class SimpleMBean
catch (AttributeNotFoundException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (MBeanException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (ReflectionException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
}
@@ -364,22 +378,22 @@ public abstract class SimpleMBean
catch (AttributeNotFoundException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (InvalidAttributeValueException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (MBeanException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
catch (ReflectionException e)
{
// TODO Auto-generated catch block
- e.printStackTrace();
+ LOG.error( e.getMessage(), e );
}
}
