This is an automated email from the ASF dual-hosted git repository. juanpablo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/jspwiki.git
commit 1c3afb74b944e692853432d3b41d5fe2a90f9473 Author: juanpablo <[email protected]> AuthorDate: Fri Nov 2 21:59:08 2018 +0100 remove warnings from tests on org.apache.jspwiki.workflow package --- .../test/java/org/apache/wiki/workflow/ApprovalWorkflowTest.java | 6 +++--- .../src/test/java/org/apache/wiki/workflow/DecisionQueueTest.java | 4 ++-- .../src/test/java/org/apache/wiki/workflow/SimpleDecisionTest.java | 6 +++--- jspwiki-main/src/test/java/org/apache/wiki/workflow/TaskTest.java | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/jspwiki-main/src/test/java/org/apache/wiki/workflow/ApprovalWorkflowTest.java b/jspwiki-main/src/test/java/org/apache/wiki/workflow/ApprovalWorkflowTest.java index 3acbbb1..6179c4f 100644 --- a/jspwiki-main/src/test/java/org/apache/wiki/workflow/ApprovalWorkflowTest.java +++ b/jspwiki-main/src/test/java/org/apache/wiki/workflow/ApprovalWorkflowTest.java @@ -106,7 +106,7 @@ public class ApprovalWorkflowTest Assertions.assertNotNull( w.getAttribute( "task.preSaveWikiPage") ); Assertions.assertEquals( new WikiPrincipal( Users.JANNE ), decision.getActor() ); Assertions.assertEquals( decisionKey, decision.getMessageKey() ); - List decisionFacts = ((Decision)decision).getFacts(); + List< Fact > decisionFacts = ((Decision)decision).getFacts(); Assertions.assertEquals( 3, decisionFacts.size() ); Assertions.assertEquals( facts[0], decisionFacts.get(0) ); Assertions.assertEquals( facts[1], decisionFacts.get(1) ); @@ -199,7 +199,7 @@ public class ApprovalWorkflowTest Assertions.assertFalse( m_engine.pageExists(pageName)); // Second, GroupPrincipal Admin should see a Decision in its queue - Collection decisions = m_dq.getActorDecisions( m_engine.adminSession() ); + Collection< Decision > decisions = m_dq.getActorDecisions( m_engine.adminSession() ); Assertions.assertEquals(1, decisions.size()); // Now, approve the decision and it should go away, and page should appear. @@ -232,7 +232,7 @@ public class ApprovalWorkflowTest Assertions.assertFalse( m_engine.pageExists(pageName)); // ...and there should be a Decision in GroupPrincipal Admin's queue - Collection decisions = m_dq.getActorDecisions( m_engine.adminSession() ); + Collection< Decision > decisions = m_dq.getActorDecisions( m_engine.adminSession() ); Assertions.assertEquals(1, decisions.size()); // Now, DENY the decision and the page should still not exist... diff --git a/jspwiki-main/src/test/java/org/apache/wiki/workflow/DecisionQueueTest.java b/jspwiki-main/src/test/java/org/apache/wiki/workflow/DecisionQueueTest.java index cf5d8da..a19241b 100644 --- a/jspwiki-main/src/test/java/org/apache/wiki/workflow/DecisionQueueTest.java +++ b/jspwiki-main/src/test/java/org/apache/wiki/workflow/DecisionQueueTest.java @@ -152,7 +152,7 @@ public class DecisionQueueTest @Test public void testActorDecisions() { - Collection decisions = m_queue.getActorDecisions(adminSession); + Collection< Decision > decisions = m_queue.getActorDecisions(adminSession); Assertions.assertEquals(1, decisions.size()); decisions = m_queue.getActorDecisions(janneSession); @@ -184,7 +184,7 @@ public class DecisionQueueTest Assertions.assertEquals(decision, w.getCurrentStep()); // Verify that it's also in Janne's DecisionQueue - Collection decisions = m_queue.getActorDecisions(janneSession); + Collection< Decision > decisions = m_queue.getActorDecisions(janneSession); Assertions.assertEquals(1, decisions.size()); Decision d = (Decision)decisions.iterator().next(); Assertions.assertEquals(decision, d); diff --git a/jspwiki-main/src/test/java/org/apache/wiki/workflow/SimpleDecisionTest.java b/jspwiki-main/src/test/java/org/apache/wiki/workflow/SimpleDecisionTest.java index d7c3c1b..a2c11b5 100644 --- a/jspwiki-main/src/test/java/org/apache/wiki/workflow/SimpleDecisionTest.java +++ b/jspwiki-main/src/test/java/org/apache/wiki/workflow/SimpleDecisionTest.java @@ -52,7 +52,7 @@ public class SimpleDecisionTest m_decision.addFact(f3); // The facts should be available, and returned in order - List facts = m_decision.getFacts(); + List< Fact > facts = m_decision.getFacts(); Assertions.assertEquals(f1, facts.get(0)); Assertions.assertEquals(f2, facts.get(1)); Assertions.assertEquals(f3, facts.get(2)); @@ -109,7 +109,7 @@ public class SimpleDecisionTest m_decision.addError("Error deciding something."); m_decision.addError("Error deciding something else."); - List errors = m_decision.getErrors(); + List< String > errors = m_decision.getErrors(); Assertions.assertEquals(2, errors.size()); Assertions.assertEquals("Error deciding something.", errors.get(0)); Assertions.assertEquals("Error deciding something else.", errors.get(1)); @@ -118,7 +118,7 @@ public class SimpleDecisionTest @Test public void testAvailableOutcomes() { - Collection outcomes = m_decision.getAvailableOutcomes(); + Collection< Outcome > outcomes = m_decision.getAvailableOutcomes(); Assertions.assertTrue(outcomes.contains(Outcome.DECISION_APPROVE)); Assertions.assertTrue(outcomes.contains(Outcome.DECISION_DENY)); Assertions.assertFalse(outcomes.contains(Outcome.DECISION_HOLD)); diff --git a/jspwiki-main/src/test/java/org/apache/wiki/workflow/TaskTest.java b/jspwiki-main/src/test/java/org/apache/wiki/workflow/TaskTest.java index bfd70c4..0eebdb1 100644 --- a/jspwiki-main/src/test/java/org/apache/wiki/workflow/TaskTest.java +++ b/jspwiki-main/src/test/java/org/apache/wiki/workflow/TaskTest.java @@ -110,7 +110,7 @@ public class TaskTest m_task.addError("Error deciding something."); m_task.addError("Error deciding something else."); - List errors = m_task.getErrors(); + List< String > errors = m_task.getErrors(); Assertions.assertEquals(2, errors.size()); Assertions.assertEquals("Error deciding something.", errors.get(0)); Assertions.assertEquals("Error deciding something else.", errors.get(1)); @@ -119,7 +119,7 @@ public class TaskTest @Test public void testAvailableOutcomes() { - Collection outcomes = m_task.getAvailableOutcomes(); + Collection< Outcome > outcomes = m_task.getAvailableOutcomes(); Assertions.assertFalse(outcomes.contains(Outcome.DECISION_APPROVE)); Assertions.assertFalse(outcomes.contains(Outcome.DECISION_DENY)); Assertions.assertFalse(outcomes.contains(Outcome.DECISION_HOLD));
