JUDDI-864 removing finalizier JUDDI-198 adding javadoc and usage scenarios
Project: http://git-wip-us.apache.org/repos/asf/juddi/repo Commit: http://git-wip-us.apache.org/repos/asf/juddi/commit/0f8e9eea Tree: http://git-wip-us.apache.org/repos/asf/juddi/tree/0f8e9eea Diff: http://git-wip-us.apache.org/repos/asf/juddi/diff/0f8e9eea Branch: refs/heads/master Commit: 0f8e9eeafef28247c7790c7bdf6e4b9a84d1a3ae Parents: e78753f Author: alexoree <[email protected]> Authored: Wed Mar 5 20:15:46 2014 -0500 Committer: alexoree <[email protected]> Committed: Wed Mar 5 20:15:46 2014 -0500 ---------------------------------------------------------------------- .../apache/juddi/client/plugins/AppTest.java | 38 +++++++++++++++++ .../SubscriptionCallbackListener.java | 7 --- .../api/impl/UDDIValueSetValidationImpl.java | 45 +++++++++++++++----- 3 files changed, 73 insertions(+), 17 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/juddi/blob/0f8e9eea/juddi-client-plugins/src/test/java/org/apache/juddi/client/plugins/AppTest.java ---------------------------------------------------------------------- diff --git a/juddi-client-plugins/src/test/java/org/apache/juddi/client/plugins/AppTest.java b/juddi-client-plugins/src/test/java/org/apache/juddi/client/plugins/AppTest.java new file mode 100644 index 0000000..295ab69 --- /dev/null +++ b/juddi-client-plugins/src/test/java/org/apache/juddi/client/plugins/AppTest.java @@ -0,0 +1,38 @@ +package org.apache.juddi.client.plugins; + +import junit.framework.Test; +import junit.framework.TestCase; +import junit.framework.TestSuite; + +/** + * Unit test for simple App. + */ +public class AppTest + extends TestCase +{ + /** + * Create the test case + * + * @param testName name of the test case + */ + public AppTest( String testName ) + { + super( testName ); + } + + /** + * @return the suite of tests being tested + */ + public static Test suite() + { + return new TestSuite( AppTest.class ); + } + + /** + * Rigourous Test :-) + */ + public void testApp() + { + assertTrue( true ); + } +} http://git-wip-us.apache.org/repos/asf/juddi/blob/0f8e9eea/juddi-client/src/main/java/org/apache/juddi/v3/client/subscription/SubscriptionCallbackListener.java ---------------------------------------------------------------------- diff --git a/juddi-client/src/main/java/org/apache/juddi/v3/client/subscription/SubscriptionCallbackListener.java b/juddi-client/src/main/java/org/apache/juddi/v3/client/subscription/SubscriptionCallbackListener.java index a872ac6..e1dd5c2 100644 --- a/juddi-client/src/main/java/org/apache/juddi/v3/client/subscription/SubscriptionCallbackListener.java +++ b/juddi-client/src/main/java/org/apache/juddi/v3/client/subscription/SubscriptionCallbackListener.java @@ -407,13 +407,6 @@ public class SubscriptionCallbackListener implements org.uddi.v3_service.UDDISub } - @Override - protected void finalize() throws Throwable { - run(); - super.finalize(); - - } - /** * shutdown hook */ http://git-wip-us.apache.org/repos/asf/juddi/blob/0f8e9eea/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDIValueSetValidationImpl.java ---------------------------------------------------------------------- diff --git a/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDIValueSetValidationImpl.java b/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDIValueSetValidationImpl.java index dfec221..e7642a1 100644 --- a/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDIValueSetValidationImpl.java +++ b/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDIValueSetValidationImpl.java @@ -28,6 +28,7 @@ import org.apache.juddi.api.util.ValueSetValidationQuery; import org.apache.juddi.v3.error.ErrorMessage; import org.apache.juddi.v3.error.FatalErrorException; import org.apache.juddi.v3.error.ValueNotAllowedException; +import org.apache.juddi.validation.vsv.AbstractSimpleValidator; import org.apache.juddi.validation.vsv.ValueSetValidator; import org.uddi.api_v3.BindingTemplate; import org.uddi.api_v3.BusinessEntity; @@ -43,9 +44,29 @@ import org.uddi.v3_service.DispositionReportFaultMessage; import org.uddi.v3_service.UDDIValueSetValidationPortType; import org.uddi.vs_v3.ValidateValues; -//@WebService(serviceName="UDDIValueSetValidationService", -// endpointInterface="org.uddi.v3_service.UDDIValueSetValidationPortType", -// targetNamespace = "urn:uddi-org:v3_service") +/** + * Implementation the UDDI v3 spec for Value Set Validation This is basically + * used to validate Keyed Reference value sets and offers validation via jUDDI's + * VSV extensibility framework.<Br><BR> + * To use this, define a tModel containing the following + * <pre><categoryBag> + * <keyedReference keyName="" + * keyValue="uddi:juddi.apache.org:servicebindings-valueset-cp" + * tModelKey="uddi:uddi.org:identifier:validatedby"/> + * </categoryBag> + * </pre>Where uddi:juddi.apache.org:servicebindings-valueset-cp + * is the binding key of the service implementing the VSV API (this service). + * <Br><BR> + * From there, you need to create a class that either implements + * {@link ValueSetValidator} or extends {@link AbstractSimpleValidator}. It must + * be in the package named org.apache.juddi.validation.vsv and must by named + * following the convention outlined in {@link #ConvertKeyToClass(java.lang.String) + * } + * + * @see ValueSetValidator + * @see AbstractSimpleValidator + * @author <a href="mailto:[email protected]";>Alex O'Ree</a> + */ public class UDDIValueSetValidationImpl extends AuthenticatedService implements UDDIValueSetValidationPortType { @@ -272,16 +293,20 @@ public class UDDIValueSetValidationImpl extends AuthenticatedService implements public static String ConvertKeyToClass(String tmodelkey) { - if (tmodelkey==null)return null; - if (tmodelkey.length() < 2) return null; - - String key =new String(new char[]{tmodelkey.charAt(0)}).toUpperCase() + tmodelkey.substring(1).toLowerCase(); + if (tmodelkey == null) { + return null; + } + if (tmodelkey.length() < 2) { + return null; + } + + String key = new String(new char[]{tmodelkey.charAt(0)}).toUpperCase() + tmodelkey.substring(1).toLowerCase(); key = key.replaceAll("[^a-zA-Z0-9 -]", ""); - + String clazz = "org.apache.juddi.validation.vsv." + key; - + return clazz; - + } public static List<String> getValidValues(String modelKey) { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
