Repository: juddi Updated Branches: refs/heads/master 9be9a865d -> d63e9c19c
JUDDI-907 test cases added Project: http://git-wip-us.apache.org/repos/asf/juddi/repo Commit: http://git-wip-us.apache.org/repos/asf/juddi/commit/d63e9c19 Tree: http://git-wip-us.apache.org/repos/asf/juddi/tree/d63e9c19 Diff: http://git-wip-us.apache.org/repos/asf/juddi/diff/d63e9c19 Branch: refs/heads/master Commit: d63e9c19c71136e4c14046a07d1325b8e35b793a Parents: 9be9a86 Author: Alex <[email protected]> Authored: Thu Jan 8 20:15:15 2015 -0500 Committer: Alex <[email protected]> Committed: Thu Jan 8 20:15:15 2015 -0500 ---------------------------------------------------------------------- .../org/apache/juddi/api/impl/JUDDIApiImpl.java | 10 ++++ .../apache/juddi/api/impl/API_141_JIRATest.java | 55 ++++++++++++++++++++ 2 files changed, 65 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/juddi/blob/d63e9c19/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java ---------------------------------------------------------------------- diff --git a/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java b/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java index 5693682..8bdf19f 100644 --- a/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java +++ b/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java @@ -87,6 +87,7 @@ import org.apache.juddi.v3.client.transport.Transport; import org.apache.juddi.v3.error.ErrorMessage; import org.apache.juddi.v3.error.FatalErrorException; import org.apache.juddi.v3.error.InvalidKeyPassedException; +import org.apache.juddi.v3.error.InvalidValueException; import org.apache.juddi.v3.error.UserMismatchException; import org.apache.juddi.v3_service.JUDDIApiPortType; import org.apache.juddi.validation.ValidateClerk; @@ -1535,9 +1536,18 @@ public class JUDDIApiImpl extends AuthenticatedService implements JUDDIApiPortTy } + /** + * {@inheritDoc } + * @param body + * @return item history or null if not found + * @throws DispositionReportFaultMessage + * @throws RemoteException + */ @Override public GetEntityHistoryMessageResponse getEntityHistory(GetEntityHistoryMessageRequest body) throws DispositionReportFaultMessage, RemoteException { long startTime = System.currentTimeMillis(); + if (body==null) + throw new InvalidValueException(new ErrorMessage("errors.NullInput")); EntityManager em = PersistenceManager.getEntityManager(); EntityTransaction tx = em.getTransaction(); try { http://git-wip-us.apache.org/repos/asf/juddi/blob/d63e9c19/juddi-core/src/test/java/org/apache/juddi/api/impl/API_141_JIRATest.java ---------------------------------------------------------------------- diff --git a/juddi-core/src/test/java/org/apache/juddi/api/impl/API_141_JIRATest.java b/juddi-core/src/test/java/org/apache/juddi/api/impl/API_141_JIRATest.java index 42ad8bb..f5ba393 100644 --- a/juddi-core/src/test/java/org/apache/juddi/api/impl/API_141_JIRATest.java +++ b/juddi-core/src/test/java/org/apache/juddi/api/impl/API_141_JIRATest.java @@ -26,6 +26,8 @@ import org.apache.commons.configuration.ConfigurationException; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.juddi.Registry; +import org.apache.juddi.api_v3.GetEntityHistoryMessageRequest; +import org.apache.juddi.api_v3.GetEntityHistoryMessageResponse; import org.apache.juddi.jaxb.PrintUDDI; import org.apache.juddi.v3.client.UDDIConstants; import org.apache.juddi.v3.client.config.UDDIClient; @@ -71,6 +73,7 @@ import org.uddi.api_v3.ServiceList; import org.uddi.api_v3.TModel; import org.uddi.api_v3.TModelDetail; import org.uddi.api_v3.TModelList; +import org.uddi.v3_service.DispositionReportFaultMessage; import org.uddi.v3_service.UDDIInquiryPortType; import org.uddi.v3_service.UDDIPublicationPortType; import org.uddi.v3_service.UDDISecurityPortType; @@ -1354,4 +1357,56 @@ public class API_141_JIRATest { Assert.fail("unexpected failure"); } } + + @Test(expected = DispositionReportFaultMessage.class) + public void testJUDDI907_ChangeHistory() throws Exception{ + JUDDIApiImpl j = new JUDDIApiImpl(); + j.getEntityHistory(null); + Assert.fail(); + } + @Test(expected = DispositionReportFaultMessage.class) + public void testJUDDI907_ChangeHistory1() throws Exception{ + JUDDIApiImpl j = new JUDDIApiImpl(); + j.getEntityHistory(new GetEntityHistoryMessageRequest()); + Assert.fail(); + } + + @Test(expected = DispositionReportFaultMessage.class) + public void testJUDDI907_ChangeHistory2() throws Exception{ + JUDDIApiImpl j = new JUDDIApiImpl(); + GetEntityHistoryMessageRequest r = new GetEntityHistoryMessageRequest(); + r.setEntityKey(TckBusiness.JOE_BUSINESS_KEY); + j.getEntityHistory(r); + Assert.fail(); + } + + @Test + public void testJUDDI907_ChangeHistory3() throws Exception{ + TckBusiness tb = new TckBusiness(publication, inquiry); + tb.saveJoePublisherBusiness(authInfoJoe); + JUDDIApiImpl j = new JUDDIApiImpl(); + GetEntityHistoryMessageRequest r = new GetEntityHistoryMessageRequest(); + r.setEntityKey(TckBusiness.JOE_BUSINESS_KEY); + r.setAuthInfo(authInfoJoe); + GetEntityHistoryMessageResponse entityHistory = j.getEntityHistory(r); + tb.deleteJoePublisherBusiness(authInfoJoe); + Assert.assertNotNull(entityHistory); + Assert.assertNotNull(entityHistory.getChangeRecords()); + Assert.assertFalse(entityHistory.getChangeRecords().getChangeRecord().isEmpty()); + } + + @Test(expected = DispositionReportFaultMessage.class) + public void testJUDDI907_ChangeHistory4() throws Exception{ + + JUDDIApiImpl j = new JUDDIApiImpl(); + GetEntityHistoryMessageRequest r = new GetEntityHistoryMessageRequest(); + r.setEntityKey(UUID.randomUUID().toString()); + r.setAuthInfo(authInfoJoe); + GetEntityHistoryMessageResponse entityHistory = j.getEntityHistory(r); + Assert.assertNotNull(entityHistory); + Assert.assertNotNull(entityHistory.getChangeRecords()); + Assert.assertTrue(entityHistory.getChangeRecords().getChangeRecord().isEmpty()); + + } + } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
