This is an automated email from the ASF dual-hosted git repository.

jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git


The following commit(s) were added to refs/heads/master by this push:
     new 39bf4760e6 SonarQube bug fixes
39bf4760e6 is described below

commit 39bf4760e64140e05c77ca971dbc6b7642b26614
Author: James Bognar <[email protected]>
AuthorDate: Wed Feb 18 15:35:17 2026 -0500

    SonarQube bug fixes
---
 .../java/org/apache/juneau/examples/rest/PhotosResource.java  |  4 ++--
 .../apache/juneau/microservice/resources/LogsResource.java    | 11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git 
a/juneau-examples/juneau-examples-rest/src/main/java/org/apache/juneau/examples/rest/PhotosResource.java
 
b/juneau-examples/juneau-examples-rest/src/main/java/org/apache/juneau/examples/rest/PhotosResource.java
index 78d51c0553..d9ae3161be 100644
--- 
a/juneau-examples/juneau-examples-rest/src/main/java/org/apache/juneau/examples/rest/PhotosResource.java
+++ 
b/juneau-examples/juneau-examples-rest/src/main/java/org/apache/juneau/examples/rest/PhotosResource.java
@@ -97,8 +97,8 @@ public class PhotosResource extends BasicRestServlet {
 
        private static final long serialVersionUID = 1L;
 
-       // Our cache of photos
-       private transient Map<Integer,Photo> photos = new ConcurrentHashMap<>();
+       /** Photo cache. Static - shared by all requests (singleton servlet). */
+       private static final Map<Integer,Photo> photos = new 
ConcurrentHashMap<>();
 
        /**
         * [HTTP PUT /photos/{id}]
diff --git 
a/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/LogsResource.java
 
b/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/LogsResource.java
index 7d7f1205bb..f62acb3180 100644
--- 
a/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/LogsResource.java
+++ 
b/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/LogsResource.java
@@ -48,7 +48,7 @@ import org.apache.juneau.rest.servlet.*;
        allowedMethodParams="*"
 )
 @HtmlConfig(uriAnchorText="PROPERTY_NAME")
-@SuppressWarnings({ "javadoc", "java:S2386" }) // S2386: Fields logDir, 
leFormatter, and allowDeletes are effectively final after @RestInit 
initialization
+@SuppressWarnings("javadoc")
 public class LogsResource extends BasicRestServlet {
        @Response(schema = @Schema(description = "File action"))
        public static class Action extends LinkString {
@@ -156,11 +156,14 @@ public class LogsResource extends BasicRestServlet {
                return new BufferedReader(new InputStreamReader(new 
FileInputStream(f), Charset.defaultCharset()));
        }
 
-       private File logDir;
+       /** Log directory path. Set once in @RestInit, shared by all requests. 
*/
+       private static File logDir;
 
-       private transient LogEntryFormatter leFormatter;
+       /** Log entry formatter. Set once in @RestInit, shared by all requests. 
*/
+       private static LogEntryFormatter leFormatter;
 
-       boolean allowDeletes;
+       /** Whether deletes are allowed. Set once in @RestInit, shared by all 
requests. */
+       private static boolean allowDeletes;
 
        @RestDelete(
                path="/*",

Reply via email to