Repository: kafka Updated Branches: refs/heads/trunk f236bc20f -> 726e23ef4
TRIVIAL: remove TODO in KafkaConsumer after KAFKA-2120 Author: Guozhang Wang <[email protected]> Closes #278 from guozhangwang/TL-KafkaConsumer Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/726e23ef Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/726e23ef Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/726e23ef Branch: refs/heads/trunk Commit: 726e23ef491637e03b0ba90c21992a639dcd158d Parents: f236bc2 Author: Guozhang Wang <[email protected]> Authored: Mon Oct 5 14:11:58 2015 -0700 Committer: Guozhang Wang <[email protected]> Committed: Mon Oct 5 14:11:58 2015 -0700 ---------------------------------------------------------------------- .../java/org/apache/kafka/clients/consumer/KafkaConsumer.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/726e23ef/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ---------------------------------------------------------------------- diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java b/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java index a8d791e..0771687 100644 --- a/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java +++ b/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java @@ -413,6 +413,7 @@ public class KafkaConsumer<K, V> implements Consumer<K, V> { private final SubscriptionState subscriptions; private final Metadata metadata; private final long retryBackoffMs; + private long requestTimeoutMs; private boolean closed = false; private Metadata.Listener metadataListener; @@ -422,10 +423,6 @@ public class KafkaConsumer<K, V> implements Consumer<K, V> { // refcount is used to allow reentrant access by the thread who has acquired currentThread private final AtomicInteger refcount = new AtomicInteger(0); - // TODO: This timeout controls how long we should wait before retrying a request. We should be able - // to leverage the work of KAFKA-2120 to get this value from configuration. - private long requestTimeoutMs; - /** * A consumer is instantiated by providing a set of key-value pairs as configuration. Valid configuration strings * are documented <a href="http://kafka.apache.org/documentation.html#consumerconfigs"; >here</a>. Values can be
