Repository: kafka Updated Branches: refs/heads/trunk 3b350cdff -> ed8748b7d
KAFKA-2578; Client Metadata internal state should be synchronized Author: Edward Ribeiro <[email protected]> Reviewers: Jason Gustafson <[email protected]>, Ismael Juma <[email protected]>, Ewen Cheslack-Postava <[email protected]> Closes #659 from ijuma/KAFKA-2578 Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/ed8748b7 Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/ed8748b7 Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/ed8748b7 Branch: refs/heads/trunk Commit: ed8748b7d17448a215ebbf68749d311aae30d7f7 Parents: 3b350cd Author: Edward Ribeiro <[email protected]> Authored: Thu Dec 10 10:01:58 2015 -0800 Committer: Ewen Cheslack-Postava <[email protected]> Committed: Thu Dec 10 10:01:58 2015 -0800 ---------------------------------------------------------------------- clients/src/main/java/org/apache/kafka/clients/Metadata.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/ed8748b7/clients/src/main/java/org/apache/kafka/clients/Metadata.java ---------------------------------------------------------------------- diff --git a/clients/src/main/java/org/apache/kafka/clients/Metadata.java b/clients/src/main/java/org/apache/kafka/clients/Metadata.java index 7e77c18..73a9f33 100644 --- a/clients/src/main/java/org/apache/kafka/clients/Metadata.java +++ b/clients/src/main/java/org/apache/kafka/clients/Metadata.java @@ -205,28 +205,28 @@ public final class Metadata { * Set state to indicate if metadata for all topics in Kafka cluster is required or not. * @param needMetadaForAllTopics boolean indicating need for metadata of all topics in cluster. */ - public void needMetadataForAllTopics(boolean needMetadaForAllTopics) { + public synchronized void needMetadataForAllTopics(boolean needMetadaForAllTopics) { this.needMetadataForAllTopics = needMetadaForAllTopics; } /** * Get whether metadata for all topics is needed or not */ - public boolean needMetadataForAllTopics() { + public synchronized boolean needMetadataForAllTopics() { return this.needMetadataForAllTopics; } /** * Add a Metadata listener that gets notified of metadata updates */ - public void addListener(Listener listener) { + public synchronized void addListener(Listener listener) { this.listeners.add(listener); } /** * Stop notifying the listener of metadata updates */ - public void removeListener(Listener listener) { + public synchronized void removeListener(Listener listener) { this.listeners.remove(listener); }
