Repository: kafka Updated Branches: refs/heads/trunk 91491986c -> 8f302c83c
KAFKA-3086: Remove unused method in MirrorMaker. Author: Jakub Nowak <[email protected]> Reviewers: Ismael Juma, Gwen Shapira, Grant Henke, Guozhang Wang Closes #758 from Mszak/kafka-3086 Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/8f302c83 Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/8f302c83 Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/8f302c83 Branch: refs/heads/trunk Commit: 8f302c83c3be0f5264a07dae73287dec81a0198d Parents: 9149198 Author: Jakub Nowak <[email protected]> Authored: Fri Jan 29 08:43:33 2016 -0800 Committer: Guozhang Wang <[email protected]> Committed: Fri Jan 29 08:43:33 2016 -0800 ---------------------------------------------------------------------- core/src/main/scala/kafka/tools/MirrorMaker.scala | 5 ----- docs/upgrade.html | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/8f302c83/core/src/main/scala/kafka/tools/MirrorMaker.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/kafka/tools/MirrorMaker.scala b/core/src/main/scala/kafka/tools/MirrorMaker.scala index f03623a..fb3762c 100755 --- a/core/src/main/scala/kafka/tools/MirrorMaker.scala +++ b/core/src/main/scala/kafka/tools/MirrorMaker.scala @@ -639,15 +639,10 @@ object MirrorMaker extends Logging with KafkaMetricsGroup { * If message.handler.args is specified. A constructor that takes in a String as argument must exist. */ trait MirrorMakerMessageHandler { - def handle(record: MessageAndMetadata[Array[Byte], Array[Byte]]): util.List[ProducerRecord[Array[Byte], Array[Byte]]] def handle(record: BaseConsumerRecord): util.List[ProducerRecord[Array[Byte], Array[Byte]]] } private object defaultMirrorMakerMessageHandler extends MirrorMakerMessageHandler { - override def handle(record: MessageAndMetadata[Array[Byte], Array[Byte]]): util.List[ProducerRecord[Array[Byte], Array[Byte]]] = { - Collections.singletonList(new ProducerRecord[Array[Byte], Array[Byte]](record.topic, record.key(), record.message())) - } - override def handle(record: BaseConsumerRecord): util.List[ProducerRecord[Array[Byte], Array[Byte]]] = { Collections.singletonList(new ProducerRecord[Array[Byte], Array[Byte]](record.topic, record.key, record.value)) } http://git-wip-us.apache.org/repos/asf/kafka/blob/8f302c83/docs/upgrade.html ---------------------------------------------------------------------- diff --git a/docs/upgrade.html b/docs/upgrade.html index d8a7719..b5aea1e 100644 --- a/docs/upgrade.html +++ b/docs/upgrade.html @@ -54,6 +54,7 @@ <ul> <li> The new broker id generation feature can be disable by setting broker.id.generation.enable to false. </li> <li> Configuration parameter log.cleaner.enable is now true by default. This means topics with a cleanup.policy=compact will now be compacted by default, and 128 MB of heap will be allocated to the cleaner process via log.cleaner.dedupe.buffer.size. You may want to review log.cleaner.dedupe.buffer.size and the other log.cleaner configuration values based on your usage of compacted topics. </li> + <li> MirrorMakerMessageHandler no longer exposes <em>handle(record: MessageAndMetadata[Array[Byte], Array[Byte]])</em> method as it was never called. </li> </ul> <h5>Deprecations in 0.9.0.0</h5>
