Repository: kafka Updated Branches: refs/heads/trunk d96866243 -> e2fafddbb
MINOR: Improve doc for num.x.threads configs Author: Edoardo Comar <[email protected]> Reviewers: Rajini Sivaram <[email protected]>, Jun Rao <[email protected]>, Ismael Juma <[email protected]> Closes #2847 from edoardocomar/MINOR-server.prop.threads.comments Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/e2fafddb Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/e2fafddb Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/e2fafddb Branch: refs/heads/trunk Commit: e2fafddbbf335a96e828b00c6ace0a0921803ad3 Parents: d968662 Author: Edoardo Comar <[email protected]> Authored: Fri May 12 13:11:20 2017 +0100 Committer: Ismael Juma <[email protected]> Committed: Fri May 12 13:14:55 2017 +0100 ---------------------------------------------------------------------- config/server.properties | 4 ++-- core/src/main/scala/kafka/server/KafkaConfig.scala | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/e2fafddb/config/server.properties ---------------------------------------------------------------------- diff --git a/config/server.properties b/config/server.properties index da72075..53b99ed 100644 --- a/config/server.properties +++ b/config/server.properties @@ -41,10 +41,10 @@ broker.id=0 # Maps listener names to security protocols, the default is for them to be the same. See the config documentation for more details #listener.security.protocol.map=PLAINTEXT:PLAINTEXT,SSL:SSL,SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_SSL:SASL_SSL -# The number of threads handling network requests +# The number of threads that the server uses for receiving requests from the network and sending responses to the network num.network.threads=3 -# The number of threads doing disk I/O +# The number of threads that the server uses for processing requests, which may include disk I/O num.io.threads=8 # The send buffer (SO_SNDBUF) used by the socket server http://git-wip-us.apache.org/repos/asf/kafka/blob/e2fafddb/core/src/main/scala/kafka/server/KafkaConfig.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala index a941fb7..708201a 100755 --- a/core/src/main/scala/kafka/server/KafkaConfig.scala +++ b/core/src/main/scala/kafka/server/KafkaConfig.scala @@ -411,8 +411,8 @@ object KafkaConfig { val MessageMaxBytesDoc = "The maximum message size that the server can receive. Note that this limit also applies " + "to the total size of a compressed batch of messages (when compression is enabled). Additionally, in versions " + "0.11 and later, all messages are written as batches and this setting applies to the total size of the batch." - val NumNetworkThreadsDoc = "the number of network threads that the server uses for handling network requests" - val NumIoThreadsDoc = "The number of io threads that the server uses for carrying out network requests" + val NumNetworkThreadsDoc = "The number of threads that the server uses for receiving requests from the network and sending responses to the network" + val NumIoThreadsDoc = "The number of threads that the server uses for processing requests, which may include disk I/O" val BackgroundThreadsDoc = "The number of threads to use for various background processing tasks" val QueuedMaxRequestsDoc = "The number of queued requests allowed before blocking the network threads" val RequestTimeoutMsDoc = CommonClientConfigs.REQUEST_TIMEOUT_MS_DOC
