Repository: kafka Updated Branches: refs/heads/0.11.0 6ed7288fd -> 22288e805
MINOR: fix flakiness in testDeleteAcls This call to isCompletedExceptionally introduced a race condition because the future might not have been completed. assertFutureError checks that the exception is present and of the correct type in any case, so the call was not necessary. Author: Colin P. Mccabe <[email protected]> Reviewers: Ismael Juma <[email protected]> Closes #3139 from cmccabe/fix-test-deleteacls (cherry picked from commit a10990f44b1a4f8345eae7ebfc9c571bfd0447c3) Signed-off-by: Ismael Juma <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/22288e80 Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/22288e80 Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/22288e80 Branch: refs/heads/0.11.0 Commit: 22288e8053e16d31be6e0e4449daa09cbe5102c1 Parents: 6ed7288 Author: Colin P. Mccabe <[email protected]> Authored: Thu May 25 11:21:00 2017 +0100 Committer: Ismael Juma <[email protected]> Committed: Thu May 25 11:21:10 2017 +0100 ---------------------------------------------------------------------- .../java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java | 1 - 1 file changed, 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/22288e80/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ---------------------------------------------------------------------- diff --git a/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java b/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java index 62c7dde..2ef654d 100644 --- a/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java @@ -288,7 +288,6 @@ public class KafkaAdminClientTest { assertEquals(ACL1, filter1Results.acls().get(0).acl()); assertEquals(null, filter1Results.acls().get(1).exception()); assertEquals(ACL2, filter1Results.acls().get(1).acl()); - assertTrue(filterResults.get(FILTER2).isCompletedExceptionally()); assertFutureError(filterResults.get(FILTER2), SecurityDisabledException.class); assertFutureError(results.all(), SecurityDisabledException.class);
