Repository: kafka Updated Branches: refs/heads/trunk 48f5f048b -> dc2322a27
MINOR: Not enough replica exception should never happen for delete records When reviewing https://github.com/apache/kafka/pull/4132, I felt that NOT_ENOUGH_REPLICAS should never happen actually. Hence proposing to remove it from the listed error code as well in the broker-side capture clause. Testing added in 4132 should have been sufficient. Author: Guozhang Wang <[email protected]> Reviewers: Ismael Juma <[email protected]>, Dong Lin <[email protected]> Closes #4208 from guozhangwang/KMinor-delete-records-error-code Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/dc2322a2 Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/dc2322a2 Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/dc2322a2 Branch: refs/heads/trunk Commit: dc2322a272c3093b3a65910fc35c383c7bb40fab Parents: 48f5f04 Author: Guozhang Wang <[email protected]> Authored: Wed Nov 15 14:36:05 2017 -0800 Committer: Guozhang Wang <[email protected]> Committed: Wed Nov 15 14:36:05 2017 -0800 ---------------------------------------------------------------------- .../org/apache/kafka/common/requests/DeleteRecordsResponse.java | 1 - core/src/main/scala/kafka/server/ReplicaManager.scala | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/dc2322a2/clients/src/main/java/org/apache/kafka/common/requests/DeleteRecordsResponse.java ---------------------------------------------------------------------- diff --git a/clients/src/main/java/org/apache/kafka/common/requests/DeleteRecordsResponse.java b/clients/src/main/java/org/apache/kafka/common/requests/DeleteRecordsResponse.java index b839bf5..4b45517 100644 --- a/clients/src/main/java/org/apache/kafka/common/requests/DeleteRecordsResponse.java +++ b/clients/src/main/java/org/apache/kafka/common/requests/DeleteRecordsResponse.java @@ -78,7 +78,6 @@ public class DeleteRecordsResponse extends AbstractResponse { * UNKNOWN_TOPIC_OR_PARTITION (3) * NOT_LEADER_FOR_PARTITION (6) * REQUEST_TIMED_OUT (7) - * NOT_ENOUGH_REPLICAS (19) * UNKNOWN (-1) */ http://git-wip-us.apache.org/repos/asf/kafka/blob/dc2322a2/core/src/main/scala/kafka/server/ReplicaManager.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/kafka/server/ReplicaManager.scala b/core/src/main/scala/kafka/server/ReplicaManager.scala index 101eaae..2de50d8 100644 --- a/core/src/main/scala/kafka/server/ReplicaManager.scala +++ b/core/src/main/scala/kafka/server/ReplicaManager.scala @@ -545,8 +545,7 @@ class ReplicaManager(val config: KafkaConfig, _: NotLeaderForPartitionException | _: OffsetOutOfRangeException | _: PolicyViolationException | - _: KafkaStorageException | - _: NotEnoughReplicasException) => + _: KafkaStorageException) => (topicPartition, LogDeleteRecordsResult(-1L, -1L, Some(e))) case t: Throwable => error("Error processing delete records operation on partition %s".format(topicPartition), t)
