This is an automated email from the ASF dual-hosted git repository.
jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 6d26690 KAFKA-4991; Resolve findbugs warnings in KerberosLogin (#4394)
6d26690 is described below
commit 6d266907cd93bc9e5b5341b9c6e9d026c4b60eee
Author: Manikumar Reddy O <[email protected]>
AuthorDate: Fri Jan 26 21:55:12 2018 +0530
KAFKA-4991; Resolve findbugs warnings in KerberosLogin (#4394)
---
.../org/apache/kafka/common/security/kerberos/KerberosLogin.java | 4 ++--
gradle/findbugs-exclude.xml | 7 -------
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git
a/clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java
b/clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java
index b43d3b0..65c3b1c 100644
---
a/clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java
+++
b/clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java
@@ -313,7 +313,7 @@ public class KerberosLogin extends AbstractLogin {
return proposedRefresh;
}
- private synchronized KerberosTicket getTGT() {
+ private KerberosTicket getTGT() {
Set<KerberosTicket> tickets =
subject.getPrivateCredentials(KerberosTicket.class);
for (KerberosTicket ticket : tickets) {
KerberosPrincipal server = ticket.getServer();
@@ -340,7 +340,7 @@ public class KerberosLogin extends AbstractLogin {
* Re-login a principal. This method assumes that {@link #login()} has
happened already.
* @throws javax.security.auth.login.LoginException on a failure
*/
- private synchronized void reLogin() throws LoginException {
+ private void reLogin() throws LoginException {
if (!isKrbTicket) {
return;
}
diff --git a/gradle/findbugs-exclude.xml b/gradle/findbugs-exclude.xml
index 66b4874..3370205 100644
--- a/gradle/findbugs-exclude.xml
+++ b/gradle/findbugs-exclude.xml
@@ -235,13 +235,6 @@ For a detailed description of findbugs bug categories, see
http://findbugs.sourc
</Match>
<Match>
- <!-- Suppress inconsistent synchronization warnings about
KerberosLogin#login.
- See KAFKA-4991 for details. -->
- <Class name="org.apache.kafka.common.security.kerberos.KerberosLogin"/>
- <Bug pattern="IS2_INCONSISTENT_SYNC"/>
- </Match>
-
- <Match>
<!-- Suppress inconsistent synchronization warnings about
AbstractCoordinator#coordinator. See KAFKA-4992 for details.-->
<Class
name="org.apache.kafka.clients.consumer.internals.AbstractCoordinator"/>
--
To stop receiving notification emails like this one, please contact
[email protected].
