This is an automated email from the ASF dual-hosted git repository.
rsivaram pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 822cd7d MINOR: Removed explicit class checks for
PolicyViolationException (#4515)
822cd7d is described below
commit 822cd7d608ca70ead1fe17fc9e69ad0c82a447be
Author: Edoardo Comar <[email protected]>
AuthorDate: Mon Feb 5 14:54:09 2018 +0000
MINOR: Removed explicit class checks for PolicyViolationException (#4515)
PolicyViolationException is a subclass of ApiException, and the handling
was identical, hence explicit checking not required.
---
core/src/main/scala/kafka/server/AdminManager.scala | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/core/src/main/scala/kafka/server/AdminManager.scala
b/core/src/main/scala/kafka/server/AdminManager.scala
index 8264f7c..9014fab 100644
--- a/core/src/main/scala/kafka/server/AdminManager.scala
+++ b/core/src/main/scala/kafka/server/AdminManager.scala
@@ -26,7 +26,7 @@ import kafka.utils._
import kafka.zk.{AdminZkClient, KafkaZkClient}
import org.apache.kafka.clients.admin.NewPartitions
import org.apache.kafka.common.config.{AbstractConfig, ConfigDef,
ConfigException, ConfigResource}
-import org.apache.kafka.common.errors.{ApiException,
InvalidPartitionsException, InvalidReplicaAssignmentException,
InvalidRequestException, PolicyViolationException,
ReassignmentInProgressException, UnknownTopicOrPartitionException}
+import org.apache.kafka.common.errors.{ApiException,
InvalidPartitionsException, InvalidReplicaAssignmentException,
InvalidRequestException, ReassignmentInProgressException,
UnknownTopicOrPartitionException}
import org.apache.kafka.common.internals.Topic
import org.apache.kafka.common.metrics.Metrics
import org.apache.kafka.common.network.ListenerName
@@ -128,7 +128,7 @@ class AdminManager(val config: KafkaConfig,
CreatePartitionsMetadata(topic, assignments, ApiError.NONE)
} catch {
// Log client errors at a lower level than unexpected exceptions
- case e@ (_: PolicyViolationException | _: ApiException) =>
+ case e: ApiException =>
info(s"Error processing create topic request for topic $topic with
arguments $arguments", e)
CreatePartitionsMetadata(topic, Map(), ApiError.fromThrowable(e))
case e: Throwable =>
@@ -398,7 +398,7 @@ class AdminManager(val config: KafkaConfig,
case e: Throwable =>
// Log client errors at a lower level than unexpected exceptions
val message = s"Error processing alter configs request for resource
$resource, config $config"
- if (e.isInstanceOf[ApiException] ||
e.isInstanceOf[PolicyViolationException])
+ if (e.isInstanceOf[ApiException])
info(message, e)
else
error(message, e)
--
To stop receiving notification emails like this one, please contact
[email protected].
