This is an automated email from the ASF dual-hosted git repository.
guozhang pushed a commit to branch 1.1
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/1.1 by this push:
new fbfaa0f KAFKA-6878: NPE when querying global state store not in READY
state (#4978)
fbfaa0f is described below
commit fbfaa0f35f3b672b21e56190cbf9fa8d375e5989
Author: tedyu <[email protected]>
AuthorDate: Wed May 9 10:42:10 2018 -0700
KAFKA-6878: NPE when querying global state store not in READY state (#4978)
Check whether cache is null before retrieving from cache.
Reviewers: Guozhang Wang <[email protected]>, Bill Bejeck
<[email protected]>
---
.../apache/kafka/streams/state/internals/CachingKeyValueStore.java | 5 ++++-
.../org/apache/kafka/streams/state/internals/CachingWindowStore.java | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
b/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
index 82a6ac7..9eebc16 100644
---
a/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
+++
b/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
@@ -163,7 +163,10 @@ class CachingKeyValueStore<K, V> extends
WrappedStateStore.AbstractStateStore im
}
private byte[] getInternal(final Bytes key) {
- final LRUCacheEntry entry = cache.get(cacheName, key);
+ LRUCacheEntry entry = null;
+ if (cache != null) {
+ entry = cache.get(cacheName, key);
+ }
if (entry == null) {
final byte[] rawValue = underlying.get(key);
if (rawValue == null) {
diff --git
a/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
b/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
index ad0bd99..7109af0 100644
---
a/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
+++
b/streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
@@ -1,3 +1,4 @@
+
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
--
To stop receiving notification emails like this one, please contact
[email protected].
