This is an automated email from the ASF dual-hosted git repository.

manikumar pushed a commit to branch 2.4
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.4 by this push:
     new 99926bd  KAFKA-9078: Fix Connect system test after adding MM2 
connector classes
99926bd is described below

commit 99926bde1fcf5ec472e96ce0aa2cd2f0bc50192b
Author: Konstantine Karantasis <[email protected]>
AuthorDate: Wed Oct 23 15:46:26 2019 +0530

    KAFKA-9078: Fix Connect system test after adding MM2 connector classes
    
    MM2 added a few connector classes in Connect's classpath and given that the 
assertion in the Connect REST system tests need to be adjusted to account for 
these additions.
    
    This fix makes sure that the loaded Connect plugins are a superset of the 
expected by the test connectors.
    
    Testing: The change is straightforward. The fix was tested with local 
system test runs.
    
    Author: Konstantine Karantasis <[email protected]>
    
    Reviewers: Manikumar Reddy <[email protected]>
    
    Closes #7578 from kkonstantine/minor-fix-connect-test-after-mm2-classes
---
 tests/kafkatest/tests/connect/connect_rest_test.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/kafkatest/tests/connect/connect_rest_test.py 
b/tests/kafkatest/tests/connect/connect_rest_test.py
index 67c0417..836b4a7 100644
--- a/tests/kafkatest/tests/connect/connect_rest_test.py
+++ b/tests/kafkatest/tests/connect/connect_rest_test.py
@@ -91,7 +91,10 @@ class ConnectRestApiTest(KafkaTest):
 
         assert self.cc.list_connectors() == []
 
-        assert set([connector_plugin['class'] for connector_plugin in 
self.cc.list_connector_plugins()]) == {self.FILE_SOURCE_CONNECTOR, 
self.FILE_SINK_CONNECTOR}
+        # After MM2 and the connector classes that it added, the assertion 
here checks that the registered
+        # Connect plugins are a superset of the connectors expected to be 
present.
+        assert set([connector_plugin['class'] for connector_plugin in 
self.cc.list_connector_plugins()]).issuperset(
+            {self.FILE_SOURCE_CONNECTOR, self.FILE_SINK_CONNECTOR})
 
         source_connector_props = self.render("connect-file-source.properties")
         sink_connector_props = self.render("connect-file-sink.properties")

Reply via email to