This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch 2.3
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.3 by this push:
     new fdcb6dd  MINOR: Remove staticmethod tag to be able to use logger of 
instance (#9086)
fdcb6dd is described below

commit fdcb6ddc731b0cbf3c06944761a85e115550ee67
Author: Bruno Cadonna <[email protected]>
AuthorDate: Mon Jul 27 18:38:14 2020 +0200

    MINOR: Remove staticmethod tag to be able to use logger of instance (#9086)
    
    A system test failed with the following error: global name 'self' is not 
defined
    
    The reason was that `self` was accessed to log a message in a static 
method. This commit makes the method an instance method.
    
    Reviewer: Matthias J. Sax <[email protected]>
---
 tests/kafkatest/tests/streams/base_streams_test.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kafkatest/tests/streams/base_streams_test.py 
b/tests/kafkatest/tests/streams/base_streams_test.py
index 256693c..2cfe27b 100644
--- a/tests/kafkatest/tests/streams/base_streams_test.py
+++ b/tests/kafkatest/tests/streams/base_streams_test.py
@@ -95,8 +95,7 @@ class BaseStreamsTest(KafkaTest):
                    timeout_sec=60,
                    err_msg="Did expect to read '%s' from %s" % (message, 
processor.node.account))
 
-    @staticmethod
-    def verify_from_file(processor, message, file):
+    def verify_from_file(self, processor, message, file):
         result = processor.node.account.ssh_output("grep -E '%s' %s | wc -l" % 
(message, file), allow_fail=False)
         try:
           return int(result)

Reply via email to