This is an automated email from the ASF dual-hosted git repository.
jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 9439677 KAFKA-12992; Make kraft configuration properties public
(#10971)
9439677 is described below
commit 943967773dd9de9c77e8203d7bde701407400f85
Author: zhaohaidao <[email protected]>
AuthorDate: Tue Jul 6 08:21:40 2021 +0800
KAFKA-12992; Make kraft configuration properties public (#10971)
This patch makes the following KRaft configurations public:
- `process.roles`
- `node.id`
- `initial.broker.registration.timeout.ms`
- `broker.heartbeat.interval.ms`
- `broker.session.timeout.ms`
- `metadata.log.dir`
- `controller.listener.names`
- `sasl.mechanism.controller.protocol`
Reviewers: Luke Chen <[email protected]>, Jason Gustafson
<[email protected]>
---
core/src/main/scala/kafka/server/KafkaConfig.scala | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala
b/core/src/main/scala/kafka/server/KafkaConfig.scala
index f89a1ec..fa8ddf0 100755
--- a/core/src/main/scala/kafka/server/KafkaConfig.scala
+++ b/core/src/main/scala/kafka/server/KafkaConfig.scala
@@ -1048,17 +1048,14 @@ object KafkaConfig {
*/
.define(MetadataSnapshotMaxNewRecordBytesProp, LONG,
Defaults.MetadataSnapshotMaxNewRecordBytes, atLeast(1), HIGH,
MetadataSnapshotMaxNewRecordBytesDoc)
- /*
- * KRaft mode private configs. Note that these configs are defined as
internal. We will make them public in the 3.0.0 release.
- */
- .defineInternal(ProcessRolesProp, LIST, Collections.emptyList(),
ValidList.in("broker", "controller"), HIGH, ProcessRolesDoc)
- .defineInternal(NodeIdProp, INT, Defaults.EmptyNodeId, null, HIGH,
NodeIdDoc)
- .defineInternal(InitialBrokerRegistrationTimeoutMsProp, INT,
Defaults.InitialBrokerRegistrationTimeoutMs, null, MEDIUM,
InitialBrokerRegistrationTimeoutMsDoc)
- .defineInternal(BrokerHeartbeatIntervalMsProp, INT,
Defaults.BrokerHeartbeatIntervalMs, null, MEDIUM, BrokerHeartbeatIntervalMsDoc)
- .defineInternal(BrokerSessionTimeoutMsProp, INT,
Defaults.BrokerSessionTimeoutMs, null, MEDIUM, BrokerSessionTimeoutMsDoc)
- .defineInternal(MetadataLogDirProp, STRING, null, null, HIGH,
MetadataLogDirDoc)
- .defineInternal(ControllerListenerNamesProp, STRING, null, null, HIGH,
ControllerListenerNamesDoc)
- .defineInternal(SaslMechanismControllerProtocolProp, STRING,
SaslConfigs.DEFAULT_SASL_MECHANISM, null, HIGH,
SaslMechanismControllerProtocolDoc)
+ .define(ProcessRolesProp, LIST, Collections.emptyList(),
ValidList.in("broker", "controller"), HIGH, ProcessRolesDoc)
+ .define(NodeIdProp, INT, Defaults.EmptyNodeId, null, HIGH, NodeIdDoc)
+ .define(InitialBrokerRegistrationTimeoutMsProp, INT,
Defaults.InitialBrokerRegistrationTimeoutMs, null, MEDIUM,
InitialBrokerRegistrationTimeoutMsDoc)
+ .define(BrokerHeartbeatIntervalMsProp, INT,
Defaults.BrokerHeartbeatIntervalMs, null, MEDIUM, BrokerHeartbeatIntervalMsDoc)
+ .define(BrokerSessionTimeoutMsProp, INT,
Defaults.BrokerSessionTimeoutMs, null, MEDIUM, BrokerSessionTimeoutMsDoc)
+ .define(MetadataLogDirProp, STRING, null, null, HIGH, MetadataLogDirDoc)
+ .define(ControllerListenerNamesProp, STRING, null, null, HIGH,
ControllerListenerNamesDoc)
+ .define(SaslMechanismControllerProtocolProp, STRING,
SaslConfigs.DEFAULT_SASL_MECHANISM, null, HIGH,
SaslMechanismControllerProtocolDoc)
/************* Authorizer Configuration ***********/
.define(AuthorizerClassNameProp, STRING, Defaults.AuthorizerClassName,
LOW, AuthorizerClassNameDoc)