[kafka] branch trunk updated: MINOR: defineInternal for KIP-405 configs (#11293)

[junrao]

This is an automated email from the ASF dual-hosted git repository.

junrao pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1338025  MINOR: defineInternal for KIP-405 configs (#11293)
1338025 is described below

commit 1338025d24deb546d15fc1b6ae3b24500404e2f2
Author: Cong Ding <c...@ccding.com>
AuthorDate: Mon Sep 20 10:49:03 2021 -0700

    MINOR: defineInternal for KIP-405 configs (#11293)
    
    We haven't finished implementing KIP-405, therefore we should make
    KIP-405 configs as defineInternal.
    
    Reviewers: Jun Rao <jun...@gmail.com>
---
 core/src/main/scala/kafka/log/LogConfig.scala         | 6 +++---
 core/src/main/scala/kafka/server/ZkAdminManager.scala | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/core/src/main/scala/kafka/log/LogConfig.scala 
b/core/src/main/scala/kafka/log/LogConfig.scala
index 05303b8..845f80a 100755
--- a/core/src/main/scala/kafka/log/LogConfig.scala
+++ b/core/src/main/scala/kafka/log/LogConfig.scala
@@ -381,9 +381,9 @@ object LogConfig {
     // config names.
     logConfigDef
       // This define method is not overridden in LogConfig as these configs do 
not have server defaults yet.
-      .define(RemoteLogStorageEnableProp, BOOLEAN, 
Defaults.RemoteLogStorageEnable, MEDIUM, RemoteLogStorageEnableDoc)
-      .define(LocalLogRetentionMsProp, LONG, Defaults.LocalRetentionMs, 
atLeast(-2), MEDIUM, LocalLogRetentionMsDoc)
-      .define(LocalLogRetentionBytesProp, LONG, Defaults.LocalRetentionBytes, 
atLeast(-2), MEDIUM, LocalLogRetentionBytesDoc)
+      .defineInternal(RemoteLogStorageEnableProp, BOOLEAN, 
Defaults.RemoteLogStorageEnable, null, MEDIUM, RemoteLogStorageEnableDoc)
+      .defineInternal(LocalLogRetentionMsProp, LONG, 
Defaults.LocalRetentionMs, atLeast(-2), MEDIUM, LocalLogRetentionMsDoc)
+      .defineInternal(LocalLogRetentionBytesProp, LONG, 
Defaults.LocalRetentionBytes, atLeast(-2), MEDIUM, LocalLogRetentionBytesDoc)
 
     logConfigDef
   }
diff --git a/core/src/main/scala/kafka/server/ZkAdminManager.scala 
b/core/src/main/scala/kafka/server/ZkAdminManager.scala
index cd26ac0..02d44cd 100644
--- a/core/src/main/scala/kafka/server/ZkAdminManager.scala
+++ b/core/src/main/scala/kafka/server/ZkAdminManager.scala
@@ -118,7 +118,7 @@ class ZkAdminManager(val config: KafkaConfig,
     metadataAndConfigs.get(topicName).foreach { result =>
       val logConfig = 
LogConfig.fromProps(LogConfig.extractLogConfigMap(config), configs)
       val createEntry = configHelper.createTopicConfigEntry(logConfig, 
configs, includeSynonyms = false, includeDocumentation = false)(_, _)
-      val topicConfigs = logConfig.values.asScala.map { case (k, v) =>
+      val topicConfigs = logConfig.nonInternalValues.asScala.map { case (k, v) 
=>
         val entry = createEntry(k, v)
         new CreatableTopicConfigs()
           .setName(k)