This is an automated email from the ASF dual-hosted git repository.

showuon pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 2b64f1a571 MINOR: Using enums for auto.offset.reset configuration 
(#12077)
2b64f1a571 is described below

commit 2b64f1a57160884754f0a3652c0bd34de21e9ad1
Author: RivenSun <[email protected]>
AuthorDate: Sun Apr 24 20:54:44 2022 +0800

    MINOR: Using enums for auto.offset.reset configuration (#12077)
    
    Using enums instead of Strings for auto.offset.reset configuration
    
    Reviewers: Divij Vaidya <[email protected]>, Luke Chen 
<[email protected]
---
 .../java/org/apache/kafka/clients/consumer/ConsumerConfig.java   | 5 +++--
 .../org/apache/kafka/clients/consumer/OffsetResetStrategy.java   | 9 ++++++++-
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git 
a/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java 
b/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
index 48f1ccbf19..6f9692cce2 100644
--- 
a/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
+++ 
b/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
@@ -28,6 +28,7 @@ import 
org.apache.kafka.common.errors.InvalidConfigurationException;
 import org.apache.kafka.common.metrics.Sensor;
 import org.apache.kafka.common.requests.JoinGroupRequest;
 import org.apache.kafka.common.serialization.Deserializer;
+import org.apache.kafka.common.utils.Utils;
 
 import java.util.Arrays;
 import java.util.Collections;
@@ -451,8 +452,8 @@ public class ConsumerConfig extends AbstractConfig {
                                         
CommonClientConfigs.RETRY_BACKOFF_MS_DOC)
                                 .define(AUTO_OFFSET_RESET_CONFIG,
                                         Type.STRING,
-                                        "latest",
-                                        in("latest", "earliest", "none"),
+                                        OffsetResetStrategy.LATEST.toString(),
+                                        
in(Utils.enumOptions(OffsetResetStrategy.class)),
                                         Importance.MEDIUM,
                                         AUTO_OFFSET_RESET_DOC)
                                 .define(CHECK_CRCS_CONFIG,
diff --git 
a/clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java
 
b/clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java
index 6d742b850a..8b2297c968 100644
--- 
a/clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java
+++ 
b/clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java
@@ -16,6 +16,13 @@
  */
 package org.apache.kafka.clients.consumer;
 
+import java.util.Locale;
+
 public enum OffsetResetStrategy {
-    LATEST, EARLIEST, NONE
+    LATEST, EARLIEST, NONE;
+
+    @Override
+    public String toString() {
+        return super.toString().toLowerCase(Locale.ROOT);
+    }
 }

Reply via email to