[kafka] branch trunk updated: MINOR: Remove code of removed metric (#12453)

[cadonna]

This is an automated email from the ASF dual-hosted git repository.

cadonna pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 5f7c99dd77 MINOR: Remove code of removed metric (#12453)
5f7c99dd77 is described below

commit 5f7c99dd77fc71982f8664d99bb3ce1b4924d34c
Author: Bruno Cadonna <cado...@apache.org>
AuthorDate: Fri Jul 29 16:53:01 2022 +0200

    MINOR: Remove code of removed metric (#12453)
    
    When we removed metric skipped-records in 3.0 we missed to
    remove some code related to that metric.
    
    Reviewer: Guozhang Wang <wangg...@gmail.com>
---
 .../processor/internals/metrics/ThreadMetrics.java       | 16 ----------------
 .../processor/internals/metrics/ThreadMetricsTest.java   |  2 --
 2 files changed, 18 deletions(-)

diff --git 
a/streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetrics.java
 
b/streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetrics.java
index 9c3e809497..eda173e532 100644
--- 
a/streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetrics.java
+++ 
b/streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetrics.java
@@ -45,7 +45,6 @@ public class ThreadMetrics {
     private static final String PUNCTUATE = "punctuate";
     private static final String CREATE_TASK = "task-created";
     private static final String CLOSE_TASK = "task-closed";
-    private static final String SKIP_RECORD = "skipped-records";
     private static final String BLOCKED_TIME = "blocked-time-ns-total";
     private static final String THREAD_START_TIME = "thread-start-time";
 
@@ -79,9 +78,6 @@ public class ThreadMetrics {
     private static final String PUNCTUATE_RATE_DESCRIPTION = RATE_DESCRIPTION 
+ PUNCTUATE_DESCRIPTION;
     private static final String PUNCTUATE_AVG_LATENCY_DESCRIPTION = "The 
average punctuate latency";
     private static final String PUNCTUATE_MAX_LATENCY_DESCRIPTION = "The 
maximum punctuate latency";
-    private static final String SKIP_RECORDS_DESCRIPTION = "skipped records";
-    private static final String SKIP_RECORD_TOTAL_DESCRIPTION = 
TOTAL_DESCRIPTION + SKIP_RECORDS_DESCRIPTION;
-    private static final String SKIP_RECORD_RATE_DESCRIPTION = 
RATE_DESCRIPTION + SKIP_RECORDS_DESCRIPTION;
     private static final String COMMIT_OVER_TASKS_DESCRIPTION =
         "calls to commit over all tasks assigned to one stream thread";
     private static final String COMMIT_OVER_TASKS_TOTAL_DESCRIPTION = 
TOTAL_DESCRIPTION + COMMIT_OVER_TASKS_DESCRIPTION;
@@ -123,18 +119,6 @@ public class ThreadMetrics {
         );
     }
 
-    public static Sensor skipRecordSensor(final String threadId,
-                                          final StreamsMetricsImpl 
streamsMetrics) {
-        return invocationRateAndCountSensor(
-            threadId,
-            SKIP_RECORD,
-            SKIP_RECORD_RATE_DESCRIPTION,
-            SKIP_RECORD_TOTAL_DESCRIPTION,
-            RecordingLevel.INFO,
-            streamsMetrics
-        );
-    }
-
     public static Sensor commitSensor(final String threadId,
                                       final StreamsMetricsImpl streamsMetrics) 
{
         return invocationRateAndCountAndAvgAndMaxLatencySensor(
diff --git 
a/streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
 
b/streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
index 3d2aaa20c8..2bbb6acb2a 100644
--- 
a/streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
+++ 
b/streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
@@ -371,8 +371,6 @@ public class ThreadMetricsTest {
             assertThat(sensor, is(expectedSensor));
         }
     }
-
-    @Test
     public void shouldGetCreateTaskSensor() {
         final String operation = "task-created";
         final String totalDescription = "The total number of newly created 
tasks";