This is an automated email from the ASF dual-hosted git repository.
mimaison pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 2ff4c0a364 MINOR: Use underscore for variable initialization in
BrokerServer (#12471)
2ff4c0a364 is described below
commit 2ff4c0a364379d231edfe1836042574359b1023e
Author: Matthew de Detrich <[email protected]>
AuthorDate: Thu Aug 18 12:26:33 2022 +0200
MINOR: Use underscore for variable initialization in BrokerServer (#12471)
In Scala its standard practice to use _ whenever you are initializing
variables. In regards to implementation, for object references _ initialization
maps to null so there is no change in behaviour.
Reviewers: Mickael Maison <[email protected]>, Divij Vaidya
<[email protected]>
---
.../src/main/scala/kafka/server/BrokerServer.scala | 50 +++++++++++-----------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/core/src/main/scala/kafka/server/BrokerServer.scala
b/core/src/main/scala/kafka/server/BrokerServer.scala
index 1008decadb..eeddff4ba3 100644
--- a/core/src/main/scala/kafka/server/BrokerServer.scala
+++ b/core/src/main/scala/kafka/server/BrokerServer.scala
@@ -95,7 +95,7 @@ class BrokerServer(
this.logIdent = logContext.logPrefix
- @volatile var lifecycleManager: BrokerLifecycleManager = null
+ @volatile var lifecycleManager: BrokerLifecycleManager = _
private val isShuttingDown = new AtomicBoolean(false)
@@ -103,54 +103,54 @@ class BrokerServer(
val awaitShutdownCond = lock.newCondition()
var status: ProcessStatus = SHUTDOWN
- @volatile var dataPlaneRequestProcessor: KafkaApis = null
- var controlPlaneRequestProcessor: KafkaApis = null
+ @volatile var dataPlaneRequestProcessor: KafkaApis = _
+ var controlPlaneRequestProcessor: KafkaApis = _
var authorizer: Option[Authorizer] = None
- @volatile var socketServer: SocketServer = null
- var dataPlaneRequestHandlerPool: KafkaRequestHandlerPool = null
+ @volatile var socketServer: SocketServer = _
+ var dataPlaneRequestHandlerPool: KafkaRequestHandlerPool = _
- var logDirFailureChannel: LogDirFailureChannel = null
- var logManager: LogManager = null
+ var logDirFailureChannel: LogDirFailureChannel = _
+ var logManager: LogManager = _
- var tokenManager: DelegationTokenManager = null
+ var tokenManager: DelegationTokenManager = _
- var dynamicConfigHandlers: Map[String, ConfigHandler] = null
+ var dynamicConfigHandlers: Map[String, ConfigHandler] = _
- @volatile private[this] var _replicaManager: ReplicaManager = null
+ @volatile private[this] var _replicaManager: ReplicaManager = _
- var credentialProvider: CredentialProvider = null
- var tokenCache: DelegationTokenCache = null
+ var credentialProvider: CredentialProvider = _
+ var tokenCache: DelegationTokenCache = _
- @volatile var groupCoordinator: GroupCoordinator = null
+ @volatile var groupCoordinator: GroupCoordinator = _
- var transactionCoordinator: TransactionCoordinator = null
+ var transactionCoordinator: TransactionCoordinator = _
- var clientToControllerChannelManager: BrokerToControllerChannelManager = null
+ var clientToControllerChannelManager: BrokerToControllerChannelManager = _
- var forwardingManager: ForwardingManager = null
+ var forwardingManager: ForwardingManager = _
- var alterPartitionManager: AlterPartitionManager = null
+ var alterPartitionManager: AlterPartitionManager = _
- var autoTopicCreationManager: AutoTopicCreationManager = null
+ var autoTopicCreationManager: AutoTopicCreationManager = _
- var kafkaScheduler: KafkaScheduler = null
+ var kafkaScheduler: KafkaScheduler = _
- @volatile var metadataCache: KRaftMetadataCache = null
+ @volatile var metadataCache: KRaftMetadataCache = _
- var quotaManagers: QuotaFactory.QuotaManagers = null
+ var quotaManagers: QuotaFactory.QuotaManagers = _
- var clientQuotaMetadataManager: ClientQuotaMetadataManager = null
+ var clientQuotaMetadataManager: ClientQuotaMetadataManager = _
- @volatile var brokerTopicStats: BrokerTopicStats = null
+ @volatile var brokerTopicStats: BrokerTopicStats = _
val clusterId: String = metaProps.clusterId
var metadataSnapshotter: Option[BrokerMetadataSnapshotter] = None
- var metadataListener: BrokerMetadataListener = null
+ var metadataListener: BrokerMetadataListener = _
- var metadataPublisher: BrokerMetadataPublisher = null
+ var metadataPublisher: BrokerMetadataPublisher = _
val brokerFeatures: BrokerFeatures = BrokerFeatures.createDefault()
