This is an automated email from the ASF dual-hosted git repository.

dajac pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 28435d74f0 MINOR: Avoid possibly resolvable name in tests (#12198)
28435d74f0 is described below

commit 28435d74f0cb80f7c6f015e8202099c9615afd5d
Author: Igor Soarez <i...@soarez.me>
AuthorDate: Fri Aug 19 13:09:20 2022 +0100

    MINOR: Avoid possibly resolvable name in tests (#12198)
    
    Reviewers: Divij Vaidya <di...@amazon.com>, David Jacot 
<dja...@confluent.io>
---
 core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala  | 4 ++--
 core/src/test/scala/unit/kafka/server/DynamicConfigTest.scala | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala 
b/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
index 8516ba3a24..30d1c3321f 100644
--- a/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
@@ -441,14 +441,14 @@ class ConfigCommandTest extends Logging {
   @Test
   def shouldFailIfUnresolvableHost(): Unit = {
     val createOpts = new ConfigCommandOptions(Array("--bootstrap-server", 
"localhost:9092",
-      "--entity-name", "admin", "--entity-type", "ips", "--describe"))
+      "--entity-name", "RFC2606.invalid", "--entity-type", "ips", 
"--describe"))
     assertThrows(classOf[IllegalArgumentException], () => 
createOpts.checkArgs())
   }
 
   @Test
   def shouldFailIfUnresolvableHostUsingZookeeper(): Unit = {
     val createOpts = new ConfigCommandOptions(Array("--zookeeper", zkConnect,
-      "--entity-name", "admin", "--entity-type", "ips", "--describe"))
+      "--entity-name", "RFC2606.invalid", "--entity-type", "ips", 
"--describe"))
     assertThrows(classOf[IllegalArgumentException], () => 
createOpts.checkArgs())
   }
 
diff --git a/core/src/test/scala/unit/kafka/server/DynamicConfigTest.scala 
b/core/src/test/scala/unit/kafka/server/DynamicConfigTest.scala
index 1fb9f33338..621c94f67e 100644
--- a/core/src/test/scala/unit/kafka/server/DynamicConfigTest.scala
+++ b/core/src/test/scala/unit/kafka/server/DynamicConfigTest.scala
@@ -66,7 +66,7 @@ class DynamicConfigTest extends QuorumTestHarness {
 
   @Test
   def shouldFailIpConfigsWithBadHost(): Unit = {
-    assertThrows(classOf[AdminOperationException], () => 
adminZkClient.changeIpConfig("ip",
+    assertThrows(classOf[AdminOperationException], () => 
adminZkClient.changeIpConfig("RFC2606.invalid",
       propsWith(QuotaConfigs.IP_CONNECTION_RATE_OVERRIDE_CONFIG, "2")))
   }
 }

Reply via email to