This is an automated email from the ASF dual-hosted git repository.

ableegoldman pushed a commit to branch 3.4
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.4 by this push:
     new 68d70cdc399 KAFKA-14533: re-enable 'false' and disable the 'true' 
parameter of SmokeTestDriverIntegrationTest (#13156)
68d70cdc399 is described below

commit 68d70cdc399ac427e1e44cc9cfcc4497ecf832c3
Author: A. Sophie Blee-Goldman <[email protected]>
AuthorDate: Tue Jan 24 00:14:20 2023 -0800

    KAFKA-14533: re-enable 'false' and disable the 'true' parameter of 
SmokeTestDriverIntegrationTest (#13156)
    
    I immediately saw a failure with stateUpdaterEnabled = true after disabling 
the false parameter, which suggests the problem actually does lie in the state 
updater itself and not the act of parametrization of the test. To verify this 
theory, and help stabilize the 3.4 release branch, let's try one more test by 
swapping out the true build in favor of the false one. If the listOffsets 
requests stop failing and causing this integration test to hit the global 
timeout as is currently happen [...]
    
    After getting in a few builds to see whether the flakiness subsides, we 
should merge this PR to re-enable both parameters going forward: 
https://github.com/apache/kafka/pull/13155
    
    Reviewers: Anna Sophie Blee-Goldman <[email protected]>
---
 .../kafka/streams/integration/SmokeTestDriverIntegrationTest.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
 
b/streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
index 6f345346949..06dd3ff0b60 100644
--- 
a/streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
+++ 
b/streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
@@ -98,8 +98,8 @@ public class SmokeTestDriverIntegrationTest {
     private static Stream<Boolean> parameters() {
         return Stream.of(
             // TODO KAFKA-14533: debug and re-enable both parameters
-            Boolean.TRUE
-            //Boolean.FALSE
+            //Boolean.TRUE
+            Boolean.FALSE
           );
     }
 

Reply via email to