This is an automated email from the ASF dual-hosted git repository.

showuon pushed a commit to branch 3.4
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.4 by this push:
     new 98f770f468f KAFKA-14295 FetchMessageConversionsPerSec meter not 
recorded (#13279)
98f770f468f is described below

commit 98f770f468f60202ac5e611fdf6c82ac30c80115
Author: Chia-Ping Tsai <[email protected]>
AuthorDate: Fri Feb 24 01:50:49 2023 +0800

    KAFKA-14295 FetchMessageConversionsPerSec meter not recorded (#13279)
    
    Reviewers: Luke Chen <[email protected]>
---
 .../src/main/java/org/apache/kafka/common/network/NetworkSend.java    | 4 ++++
 core/src/main/scala/kafka/server/KafkaApis.scala                      | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/clients/src/main/java/org/apache/kafka/common/network/NetworkSend.java 
b/clients/src/main/java/org/apache/kafka/common/network/NetworkSend.java
index 2a51a56932f..f2977b9d9e5 100644
--- a/clients/src/main/java/org/apache/kafka/common/network/NetworkSend.java
+++ b/clients/src/main/java/org/apache/kafka/common/network/NetworkSend.java
@@ -31,6 +31,10 @@ public class NetworkSend implements Send {
         return destinationId;
     }
 
+    public Send send() {
+        return send;
+    }
+
     @Override
     public boolean completed() {
         return send.completed();
diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala 
b/core/src/main/scala/kafka/server/KafkaApis.scala
index e9854f23b1d..2a053c70889 100644
--- a/core/src/main/scala/kafka/server/KafkaApis.scala
+++ b/core/src/main/scala/kafka/server/KafkaApis.scala
@@ -54,7 +54,7 @@ import 
org.apache.kafka.common.message.OffsetForLeaderEpochRequestData.OffsetFor
 import 
org.apache.kafka.common.message.OffsetForLeaderEpochResponseData.{EpochEndOffset,
 OffsetForLeaderTopicResult, OffsetForLeaderTopicResultCollection}
 import org.apache.kafka.common.message._
 import org.apache.kafka.common.metrics.Metrics
-import org.apache.kafka.common.network.{ListenerName, Send}
+import org.apache.kafka.common.network.{ListenerName, NetworkSend, Send}
 import org.apache.kafka.common.protocol.{ApiKeys, ApiMessage, Errors}
 import org.apache.kafka.common.record._
 import org.apache.kafka.common.replica.ClientMetadata
@@ -889,6 +889,8 @@ class KafkaApis(val requestChannel: RequestChannel,
             send.recordConversionStats.asScala.toMap.foreach {
               case (tp, stats) => updateRecordConversionStats(request, tp, 
stats)
             }
+          case send: NetworkSend =>
+            updateConversionStats(send.send())
           case _ =>
         }
       }

Reply via email to