[kafka] branch trunk updated: KAFKA-14809 Fix logging conditional on WorkerSourceTask (#13386)

[cegerton]

This is an automated email from the ASF dual-hosted git repository.

cegerton pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 7bf1906132b KAFKA-14809 Fix logging conditional on WorkerSourceTask 
(#13386)
7bf1906132b is described below

commit 7bf1906132b84b3350bba0569da2d6fe94c75dbd
Author: Hector Geraldino <hgerald...@gmail.com>
AuthorDate: Thu Mar 16 08:39:31 2023 -0400

    KAFKA-14809 Fix logging conditional on WorkerSourceTask (#13386)
    
    Reviewers: Chris Egerton <chr...@aiven.io>
---
 .../org/apache/kafka/connect/runtime/WorkerSourceTask.java | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
 
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
index f136b2a5f4f..a6767675a3a 100644
--- 
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
+++ 
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
@@ -216,7 +216,7 @@ class WorkerSourceTask extends AbstractWorkerSourceTask {
             this.committableOffsets = CommittableOffsets.EMPTY;
         }
 
-        if (committableOffsets.isEmpty()) {
+        if (offsetsToCommit.isEmpty()) {
             log.debug("{} Either no records were produced by the task since 
the last offset commit, " 
                     + "or every record has been filtered out by a 
transformation " 
                     + "or dropped due to transformation or conversion errors.",
@@ -225,15 +225,15 @@ class WorkerSourceTask extends AbstractWorkerSourceTask {
             // We continue with the offset commit process here instead of 
simply returning immediately
             // in order to invoke SourceTask::commit and record metrics for a 
successful offset commit
         } else {
-            log.info("{} Committing offsets for {} acknowledged messages", 
this, committableOffsets.numCommittableMessages());
-            if (committableOffsets.hasPending()) {
+            log.info("{} Committing offsets for {} acknowledged messages", 
this, offsetsToCommit.numCommittableMessages());
+            if (offsetsToCommit.hasPending()) {
                 log.debug("{} There are currently {} pending messages spread 
across {} source partitions whose offsets will not be committed. "
                                 + "The source partition with the most pending 
messages is {}, with {} pending messages",
                         this,
-                        committableOffsets.numUncommittableMessages(),
-                        committableOffsets.numDeques(),
-                        committableOffsets.largestDequePartition(),
-                        committableOffsets.largestDequeSize()
+                        offsetsToCommit.numUncommittableMessages(),
+                        offsetsToCommit.numDeques(),
+                        offsetsToCommit.largestDequePartition(),
+                        offsetsToCommit.largestDequeSize()
                 );
             } else {
                 log.debug("{} There are currently no pending messages for this 
offset commit; "