This is an automated email from the ASF dual-hosted git repository.
cegerton pushed a commit to branch 3.2
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/3.2 by this push:
new 644a2dcec20 KAFKA-14809 Fix logging conditional on WorkerSourceTask
(#13386)
644a2dcec20 is described below
commit 644a2dcec20b9b75b0eb820bb740f8d974861bf7
Author: Hector Geraldino <[email protected]>
AuthorDate: Thu Mar 16 08:39:31 2023 -0400
KAFKA-14809 Fix logging conditional on WorkerSourceTask (#13386)
Reviewers: Chris Egerton <[email protected]>
---
.../org/apache/kafka/connect/runtime/WorkerSourceTask.java | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
index a3d9b036c24..27279ea9000 100644
---
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
+++
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
@@ -494,7 +494,7 @@ class WorkerSourceTask extends WorkerTask {
this.committableOffsets = CommittableOffsets.EMPTY;
}
- if (committableOffsets.isEmpty()) {
+ if (offsetsToCommit.isEmpty()) {
log.debug("{} Either no records were produced by the task since
the last offset commit, "
+ "or every record has been filtered out by a
transformation "
+ "or dropped due to transformation or conversion errors.",
@@ -503,15 +503,15 @@ class WorkerSourceTask extends WorkerTask {
// We continue with the offset commit process here instead of
simply returning immediately
// in order to invoke SourceTask::commit and record metrics for a
successful offset commit
} else {
- log.info("{} Committing offsets for {} acknowledged messages",
this, committableOffsets.numCommittableMessages());
- if (committableOffsets.hasPending()) {
+ log.info("{} Committing offsets for {} acknowledged messages",
this, offsetsToCommit.numCommittableMessages());
+ if (offsetsToCommit.hasPending()) {
log.debug("{} There are currently {} pending messages spread
across {} source partitions whose offsets will not be committed. "
+ "The source partition with the most pending
messages is {}, with {} pending messages",
this,
- committableOffsets.numUncommittableMessages(),
- committableOffsets.numDeques(),
- committableOffsets.largestDequePartition(),
- committableOffsets.largestDequeSize()
+ offsetsToCommit.numUncommittableMessages(),
+ offsetsToCommit.numDeques(),
+ offsetsToCommit.largestDequePartition(),
+ offsetsToCommit.largestDequeSize()
);
} else {
log.debug("{} There are currently no pending messages for this
offset commit; "