This is an automated email from the ASF dual-hosted git repository.
showuon pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new e1913d2e4eb MINOR: Add log segment unit tests, If the maximum offset
beyond index, appen… (#13584)
e1913d2e4eb is described below
commit e1913d2e4eb47a4aeefa472c2f6220708339a25e
Author: 蓝士钦 <[email protected]>
AuthorDate: Thu Jun 1 17:06:12 2023 +0800
MINOR: Add log segment unit tests, If the maximum offset beyond index,
appen… (#13584)
Add log segment unit tests, If the maximum offset beyond index, appended to
the log section, it throws LogSegmentOffsetOverflowException
*More detailed description of change
The unit tests for the log segment should cover more scenario validation,
and the unit tests submitted this time cover LogSegmentOffsetOverflowException
that are expected to be thrown when the maximum index is exceeded
Reviewers: Luke Chen <[email protected]>, Divij Vaidya <[email protected]>,
Alexandre Dupriez <[email protected]>
---
.../test/scala/unit/kafka/log/LogSegmentTest.scala | 28 ++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
b/core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
index c2b108016c8..65088b7dae3 100644
--- a/core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
+++ b/core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
@@ -16,6 +16,7 @@
*/
package kafka.log
+import kafka.common.LogSegmentOffsetOverflowException
import kafka.utils.TestUtils
import kafka.utils.TestUtils.checkEquals
import org.apache.kafka.common.TopicPartition
@@ -27,6 +28,8 @@ import
org.apache.kafka.storage.internals.epoch.LeaderEpochFileCache
import org.apache.kafka.storage.internals.log.{BatchMetadata, EpochEntry,
LogConfig, ProducerStateEntry, ProducerStateManager,
ProducerStateManagerConfig, RollParams}
import org.junit.jupiter.api.Assertions._
import org.junit.jupiter.api.{AfterEach, BeforeEach, Test}
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.CsvSource
import java.io.File
import java.util
@@ -65,6 +68,31 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffsetOverflowException should be thrown while appending the
logs if:
+ * 1. largestOffset - baseOffset < 0
+ * 2. largestOffset - baseOffset > Integer.MAX_VALUE
+ */
+ @ParameterizedTest
+ @CsvSource(Array(
+ "0, -2147483648",
+ "0, 2147483648",
+ "1, 0",
+ "100, 10",
+ "2147483648, 0",
+ "-2147483648, 0",
+ "2147483648,4294967296"
+ ))
+ def testAppendForLogSegmentOffsetOverflowException(baseOffset: Long,
largestOffset: Long): Unit = {
+ val seg = createSegment(baseOffset)
+ val currentTime = Time.SYSTEM.milliseconds()
+ val shallowOffsetOfMaxTimestamp = largestOffset
+ val memoryRecords = records(0, "hello")
+ assertThrows(classOf[LogSegmentOffsetOverflowException], () => {
+ seg.append(largestOffset, currentTime, shallowOffsetOfMaxTimestamp,
memoryRecords)
+ })
+ }
+
/**
* A read on an empty log segment should return null
*/
