This is an automated email from the ASF dual-hosted git repository.
divijv pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new ba5e1acdfb8 MINOR: fix typos for metadata (#13889)
ba5e1acdfb8 is described below
commit ba5e1acdfb86c8325ed00b69fb6605190c1a9b1c
Author: minjian.cai <[email protected]>
AuthorDate: Wed Jun 21 21:09:15 2023 +0800
MINOR: fix typos for metadata (#13889)
Reviewers: Divij Vaidya <[email protected]>, Deqi Hu <[email protected]>
---
.../org/apache/kafka/controller/ReplicationControlManager.java | 6 +++---
.../kafka/metadata/migration/KRaftMigrationZkWriter.java | 10 +++++-----
.../org/apache/kafka/controller/FeatureControlManagerTest.java | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git
a/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
b/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
index 6bb754d5b29..f7d5e69ed8b 100644
---
a/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
+++
b/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
@@ -1490,10 +1490,10 @@ public class ReplicationControlManager {
ControllerResult<Boolean> maybeBalancePartitionLeaders() {
List<ApiMessageAndVersion> records = new ArrayList<>();
- boolean rescheduleImmidiately = false;
+ boolean rescheduleImmediately = false;
for (TopicIdPartition topicPartition : imbalancedPartitions) {
if (records.size() >= maxElectionsPerImbalance) {
- rescheduleImmidiately = true;
+ rescheduleImmediately = true;
break;
}
@@ -1521,7 +1521,7 @@ public class ReplicationControlManager {
builder.build().ifPresent(records::add);
}
- return ControllerResult.of(records, rescheduleImmidiately);
+ return ControllerResult.of(records, rescheduleImmediately);
}
ControllerResult<List<CreatePartitionsTopicResult>> createPartitions(
diff --git
a/metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java
b/metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java
index 046ab2fdc12..27708210c2a 100644
---
a/metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java
+++
b/metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java
@@ -66,7 +66,7 @@ public class KRaftMigrationZkWriter {
private static final String CREATE_TOPIC = "CreateTopic";
private static final String UPDATE_TOPIC = "UpdateTopic";
private static final String DELETE_TOPIC = "DeleteTopic";
- private static final String UPDATE_PARTITON = "UpdatePartition";
+ private static final String UPDATE_PARTITION = "UpdatePartition";
private static final String DELETE_PARTITION = "DeletePartition";
private static final String UPDATE_BROKER_CONFIG = "UpdateBrokerConfig";
private static final String DELETE_BROKER_CONFIG = "DeleteBrokerConfig";
@@ -232,7 +232,7 @@ public class KRaftMigrationZkWriter {
newPartitions.forEach((topicId, partitionMap) -> {
TopicImage topic = topicsImage.getTopic(topicId);
operationConsumer.accept(
- UPDATE_PARTITON,
+ UPDATE_PARTITION,
"Creating additional partitions for Topic " + topic.name() +
", ID " + topicId,
migrationState ->
migrationClient.topicClient().updateTopicPartitions(
Collections.singletonMap(topic.name(), partitionMap),
@@ -242,7 +242,7 @@ public class KRaftMigrationZkWriter {
changedPartitions.forEach((topicId, partitionMap) -> {
TopicImage topic = topicsImage.getTopic(topicId);
operationConsumer.accept(
- UPDATE_PARTITON,
+ UPDATE_PARTITION,
"Updating Partitions for Topic " + topic.name() + ", ID " +
topicId,
migrationState ->
migrationClient.topicClient().updateTopicPartitions(
Collections.singletonMap(topic.name(), partitionMap),
@@ -295,7 +295,7 @@ public class KRaftMigrationZkWriter {
Map<Integer, PartitionRegistration> changedPartitions =
topicDelta.partitionChanges();
if (!newPartitions.isEmpty()) {
operationConsumer.accept(
- UPDATE_PARTITON,
+ UPDATE_PARTITION,
"Create new partitions for Topic " + topicDelta.name()
+ ", ID " + topicId,
migrationState ->
migrationClient.topicClient().createTopicPartitions(
Collections.singletonMap(topicDelta.name(),
newPartitions),
@@ -306,7 +306,7 @@ public class KRaftMigrationZkWriter {
// Need a final for the lambda
final Map<Integer, PartitionRegistration>
finalChangedPartitions = changedPartitions;
operationConsumer.accept(
- UPDATE_PARTITON,
+ UPDATE_PARTITION,
"Updating Partitions for Topic " + topicDelta.name() +
", ID " + topicId,
migrationState ->
migrationClient.topicClient().updateTopicPartitions(
Collections.singletonMap(topicDelta.name(),
finalChangedPartitions),
diff --git
a/metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java
b/metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java
index bd9483ff5d8..bd4db845041 100644
---
a/metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java
+++
b/metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java
@@ -369,7 +369,7 @@ public class FeatureControlManagerTest {
}
@Test
- public void testCanotDowngradeBefore3_3_IV0() {
+ public void testCannotDowngradeBefore3_3_IV0() {
FeatureControlManager manager = new FeatureControlManager.Builder().
setQuorumFeatures(features(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_0_IV0.featureLevel(),
MetadataVersion.IBP_3_3_IV3.featureLevel())).
