[kafka] branch trunk updated: KAFKA-15547: Fix thread leak in MirrorMakerConfigTest (#14487)

[yashmayya]

This is an automated email from the ASF dual-hosted git repository.

yashmayya pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new fbc39bcdbe5 KAFKA-15547: Fix thread leak in MirrorMakerConfigTest 
(#14487)
fbc39bcdbe5 is described below

commit fbc39bcdbe5ebcb07435f467b77f4b7df2e910f4
Author: kpatelatwork <kpa...@confluent.io>
AuthorDate: Wed Oct 4 23:49:15 2023 -0500

    KAFKA-15547: Fix thread leak in MirrorMakerConfigTest (#14487)
    
    Reviewers: Akhilesh Chaganti <akhilesh...@users.noreply.github.com>, Rajini 
Sivaram <rajinisiva...@googlemail.com>, Yash Mayya <yash.ma...@gmail.com>
---
 .../apache/kafka/connect/mirror/MirrorMakerConfigTest.java   | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git 
a/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java
 
b/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java
index 9e4a8c62321..fe6011d2033 100644
--- 
a/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java
+++ 
b/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java
@@ -108,8 +108,10 @@ public class MirrorMakerConfigTest {
             "replication.policy.separator is honored");
         assertEquals(clusterABootstrap, 
aClientConfig.adminConfig().get("bootstrap.servers"),
             "client configs include bootstrap.servers");
-        assertEquals(ForwardingAdmin.class.getName(), 
aClientConfig.forwardingAdmin(aClientConfig.adminConfig()).getClass().getName(),
-                "Cluster a uses the default ForwardingAdmin");
+        try (ForwardingAdmin forwardingAdmin = 
aClientConfig.forwardingAdmin(aClientConfig.adminConfig())) {
+            assertEquals(ForwardingAdmin.class.getName(), 
forwardingAdmin.getClass().getName(),
+                    "Cluster a uses the default ForwardingAdmin");
+        }
         assertEquals("PLAINTEXT", 
aClientConfig.adminConfig().get("security.protocol"),
             "client configs include security.protocol");
         assertEquals("SSL", 
aClientConfig.producerConfig().get("security.protocol"),
@@ -126,8 +128,10 @@ public class MirrorMakerConfigTest {
             "client configs should not include metrics reporter");
         
assertFalse(bClientConfig.adminConfig().containsKey("metrics.reporter"),
             "client configs should not include metrics reporter");
-        assertEquals(FakeForwardingAdmin.class.getName(), 
bClientConfig.forwardingAdmin(bClientConfig.adminConfig()).getClass().getName(),
-                "Cluster b should use the FakeForwardingAdmin");
+        try (ForwardingAdmin forwardingAdmin = 
bClientConfig.forwardingAdmin(bClientConfig.adminConfig())) {
+            assertEquals(FakeForwardingAdmin.class.getName(), 
forwardingAdmin.getClass().getName(),
+                    "Cluster b should use the FakeForwardingAdmin");
+        }
     }
 
     @Test