This is an automated email from the ASF dual-hosted git repository.
jsancio pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 786d2c9975c KAFKA-17276; replicaDirectoryId for Fetch and
FetchSnapshot should be ignorable (#16819)
786d2c9975c is described below
commit 786d2c9975c7715b4f9959c2d2d40cde66e08e65
Author: Ken Huang <[email protected]>
AuthorDate: Thu Aug 8 08:53:15 2024 +0800
KAFKA-17276; replicaDirectoryId for Fetch and FetchSnapshot should be
ignorable (#16819)
The replicaDirectoryId field for FetchRequest and FetchSnapshotRequest
should be ignorable. This allows data objects with the directory id to be
serialized to any version of the requests.
Reviewers: José Armando García Sancio <[email protected]>, Chia-Ping Tsai
<[email protected]>
---
clients/src/main/resources/common/message/FetchRequest.json | 2 +-
clients/src/main/resources/common/message/FetchSnapshotRequest.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/clients/src/main/resources/common/message/FetchRequest.json
b/clients/src/main/resources/common/message/FetchRequest.json
index 228e9e4ff28..f92ccefb8dc 100644
--- a/clients/src/main/resources/common/message/FetchRequest.json
+++ b/clients/src/main/resources/common/message/FetchRequest.json
@@ -103,7 +103,7 @@
"about": "The earliest available offset of the follower replica.
The field is only used when the request is sent by the follower."},
{ "name": "PartitionMaxBytes", "type": "int32", "versions": "0+",
"about": "The maximum bytes to fetch from this partition. See
KIP-74 for cases where this limit may not be honored." },
- { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "17+",
"taggedVersions": "17+", "tag": 0,
+ { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "17+",
"taggedVersions": "17+", "tag": 0, "ignorable": true,
"about": "The directory id of the follower fetching" }
]}
]},
diff --git
a/clients/src/main/resources/common/message/FetchSnapshotRequest.json
b/clients/src/main/resources/common/message/FetchSnapshotRequest.json
index 9d50722d935..c43eeb4ce09 100644
--- a/clients/src/main/resources/common/message/FetchSnapshotRequest.json
+++ b/clients/src/main/resources/common/message/FetchSnapshotRequest.json
@@ -46,7 +46,7 @@
},
{ "name": "Position", "type": "int64", "versions": "0+",
"about": "The byte position within the snapshot to start
fetching from" },
- { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "1+",
"taggedVersions": "1+", "tag": 0,
+ { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "1+",
"taggedVersions": "1+", "tag": 0, "ignorable": true,
"about": "The directory id of the follower fetching" }
]
}
