(kafka) branch trunk updated: MINOR: add missing @Override annotations

[mjsax]

This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new b527691e0a7 MINOR: add missing @Override annotations
b527691e0a7 is described below

commit b527691e0a7d9aaef6793aaac57ba0e2b909e9d5
Author: Matthias J. Sax <matth...@confluent.io>
AuthorDate: Mon Jul 29 16:32:51 2024 -0700

    MINOR: add missing @Override annotations
---
 .../kstream/internals/KStreamKStreamJoinLeftSide.java  |  1 +
 .../kstream/internals/KStreamKStreamJoinRightSide.java |  1 +
 .../processor/internals/DefaultStateUpdaterTest.java   | 18 +++++++++---------
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git 
a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinLeftSide.java
 
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinLeftSide.java
index 1a1fbdffb2d..2309033b232 100644
--- 
a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinLeftSide.java
+++ 
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinLeftSide.java
@@ -58,6 +58,7 @@ class KStreamKStreamJoinLeftSide<K, VLeft, VRight, VOut> 
extends KStreamKStreamJ
             return TimestampedKeyAndJoinSide.makeRight(key, timestamp);
         }
 
+        @Override
         public VLeft thisValue(final LeftOrRightValue<? extends VLeft, ? 
extends VRight> leftOrRightValue) {
             return leftOrRightValue.leftValue();
         }
diff --git 
a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinRightSide.java
 
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinRightSide.java
index d09593f3b28..e9cb8b82ff1 100644
--- 
a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinRightSide.java
+++ 
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinRightSide.java
@@ -57,6 +57,7 @@ class KStreamKStreamJoinRightSide<K, VLeft, VRight, VOut> 
extends KStreamKStream
             return TimestampedKeyAndJoinSide.makeLeft(key, timestamp);
         }
 
+        @Override
         public VRight thisValue(final LeftOrRightValue<? extends VLeft, ? 
extends VRight> leftOrRightValue) {
             return leftOrRightValue.rightValue();
         }
diff --git 
a/streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java
 
b/streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java
index 666415a337b..df9023f801c 100644
--- 
a/streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java
+++ 
b/streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java
@@ -1480,7 +1480,7 @@ class DefaultStateUpdaterTest {
         stateUpdater.add(activeTask2);
         stateUpdater.add(standbyTask3);
 
-        verifyTasks(mkSet(activeTask1, activeTask2), mkSet(standbyTask1, 
standbyTask2, standbyTask3));
+        verifyGetTasks(mkSet(activeTask1, activeTask2), mkSet(standbyTask1, 
standbyTask2, standbyTask3));
     }
 
     @Test
@@ -1500,7 +1500,7 @@ class DefaultStateUpdaterTest {
         stateUpdater.add(standbyTask3);
         verifyUpdatingTasks(activeTask1, activeTask2, standbyTask1, 
standbyTask2, standbyTask3);
 
-        verifyTasks(mkSet(activeTask1, activeTask2), mkSet(standbyTask1, 
standbyTask2, standbyTask3));
+        verifyGetTasks(mkSet(activeTask1, activeTask2), mkSet(standbyTask1, 
standbyTask2, standbyTask3));
     }
 
     @Test
@@ -1514,11 +1514,11 @@ class DefaultStateUpdaterTest {
         stateUpdater.add(activeTask2);
         verifyRestoredActiveTasks(activeTask1, activeTask2);
 
-        verifyTasks(mkSet(activeTask1, activeTask2), mkSet());
+        verifyGetTasks(mkSet(activeTask1, activeTask2), mkSet());
 
         stateUpdater.drainRestoredActiveTasks(Duration.ofMinutes(1));
 
-        verifyTasks(mkSet(), mkSet());
+        verifyGetTasks(mkSet(), mkSet());
     }
 
     @Test
@@ -1548,11 +1548,11 @@ class DefaultStateUpdaterTest {
         final ExceptionAndTask expectedExceptionAndTasks3 = new 
ExceptionAndTask(streamsException, activeTask1);
         verifyExceptionsAndFailedTasks(expectedExceptionAndTasks1, 
expectedExceptionAndTasks2, expectedExceptionAndTasks3);
 
-        verifyTasks(mkSet(activeTask1), mkSet(standbyTask1, standbyTask2));
+        verifyGetTasks(mkSet(activeTask1), mkSet(standbyTask1, standbyTask2));
 
         stateUpdater.drainExceptionsAndFailedTasks();
 
-        verifyTasks(mkSet(), mkSet());
+        verifyGetTasks(mkSet(), mkSet());
     }
 
     @Test
@@ -1568,7 +1568,7 @@ class DefaultStateUpdaterTest {
 
         verifyPausedTasks(activeTask, standbyTask);
 
-        verifyTasks(mkSet(activeTask), mkSet(standbyTask));
+        verifyGetTasks(mkSet(activeTask), mkSet(standbyTask));
     }
 
     @Test
@@ -1681,8 +1681,8 @@ class DefaultStateUpdaterTest {
         assertThat((T) metrics.metrics().get(metricName).metricValue(), 
matcher);
     }
 
-    private void verifyTasks(final Set<StreamTask> expectedActiveTasks,
-                             final Set<StandbyTask> expectedStandbyTasks) {
+    private void verifyGetTasks(final Set<StreamTask> expectedActiveTasks,
+                                final Set<StandbyTask> expectedStandbyTasks) {
         final Set<Task> tasks = stateUpdater.tasks();
 
         assertEquals(expectedActiveTasks.size() + expectedStandbyTasks.size(), 
tasks.size());