(kafka) branch trunk updated: KAFKA-17571; Revert "MINOR: Log pending join members (#17219)" (#17274)

[dajac]

This is an automated email from the ASF dual-hosted git repository.

dajac pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new bd94a739eff KAFKA-17571; Revert "MINOR: Log pending join members 
(#17219)" (#17274)
bd94a739eff is described below

commit bd94a739eff341b1c4fce09431d4344e430b1c75
Author: David Jacot <dja...@confluent.io>
AuthorDate: Thu Sep 26 09:04:32 2024 +0200

    KAFKA-17571; Revert "MINOR: Log pending join members (#17219)" (#17274)
    
    This reverts commit 74bebf6e3dfdc9de6894d656bdbbb28a4c33eda8.
    
    Reviewers: David Arthur <mum...@gmail.com>, Chia-Ping Tsai 
<chia7...@gmail.com>
---
 .../org/apache/kafka/coordinator/group/GroupMetadataManager.java   | 2 +-
 .../org/apache/kafka/coordinator/group/classic/ClassicGroup.java   | 7 -------
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
index ecf7efaad49..b367009a621 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
@@ -4049,7 +4049,7 @@ public class GroupMetadataManager {
         if (!group.hasAllMembersJoined()) {
             log.debug("Cannot complete join phase of group {} because not all 
the members have rejoined. " +
                 "Members={}, AwaitingJoinResponses={}, PendingJoinMembers={}.",
-                group.groupId(), group.numMembers(), 
group.numAwaitingJoinResponse(), String.join(",", group.pendingJoinMembers()));
+                group.groupId(), group.numMembers(), 
group.numAwaitingJoinResponse(), group.numPendingJoinMembers());
             return EMPTY_RESULT;
         }
 
diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
index 45fffdee65b..907380289e6 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
@@ -609,13 +609,6 @@ public class ClassicGroup implements Group {
         return pendingJoinMembers.contains(memberId);
     }
 
-    /**
-     * @return The set of pending join members.
-     */
-    public Set<String> pendingJoinMembers() {
-        return Collections.unmodifiableSet(pendingJoinMembers);
-    }
-
     /**
      * Add a pending member.
      *