This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new f9215dae3b6 KAFKA-12770 introduce `checkstyleVersion` gradle property 
(for overriding CheckStyle project-defined dependency version) (#10967)
f9215dae3b6 is described below

commit f9215dae3b60acaee09a59c9b598d7ea71b50915
Author: Dejan Stojadinović <[email protected]>
AuthorDate: Mon Dec 2 14:14:30 2024 +0100

    KAFKA-12770 introduce `checkstyleVersion` gradle property (for overriding 
CheckStyle project-defined dependency version) (#10967)
    
    Reviewers: Ken Huang <[email protected]>, Luke Chen <[email protected]>, 
Chia-Ping Tsai <[email protected]>
---
 README.md                  | 1 +
 gradle/dependencies.gradle | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 8423f31f13e..7b24660e080 100644
--- a/README.md
+++ b/README.md
@@ -177,6 +177,7 @@ You can run checkstyle using:
 
 The checkstyle warnings will be found in 
`reports/checkstyle/reports/main.html` and 
`reports/checkstyle/reports/test.html` files in the
 subproject build directories. They are also printed to the console. The build 
will fail if Checkstyle fails.
+For experiments (or regression testing purposes) add 
`-PcheckstyleVersion=X.y.z` switch (to override project-defined checkstyle 
version).
 
 #### Spotless ####
 The import order is a part of static check. please call `spotlessApply` to 
optimize the imports of Java codes before filing pull request.
diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 5048bcd3a13..59b523ed337 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -61,7 +61,7 @@ versions += [
   // when updating checkstyle, check whether the exclusion of
   // CVE-2023-2976 and CVE-2020-8908 can be dropped from
   // gradle/resources/dependencycheck-suppressions.xml
-  checkstyle: "8.36.2",
+  checkstyle: project.hasProperty('checkstyleVersion') ? checkstyleVersion : 
"8.36.2",
   commonsCli: "1.4",
   commonsIo: "2.14.0", // ZooKeeper dependency. Do not use, this is going away.
   commonsValidator: "1.9.0",

Reply via email to