(kafka) branch kip1071 updated: MINOR: Fix epoch validation (#18065)

[lucasbru]

This is an automated email from the ASF dual-hosted git repository.

lucasbru pushed a commit to branch kip1071
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/kip1071 by this push:
     new b4852887186 MINOR: Fix epoch validation (#18065)
b4852887186 is described below

commit b4852887186584827a4174ae560ca9c3d1ead282
Author: Lucas Brutschy <lbruts...@confluent.io>
AuthorDate: Thu Dec 5 18:17:05 2024 +0100

    MINOR: Fix epoch validation (#18065)
    
    We accidentally broke the epoch validation, throwing
    on all epochs > 0. This is just the fix. We should improve
    unit test coverage though (there is a ticket for it).
---
 .../java/org/apache/kafka/coordinator/group/GroupMetadataManager.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
index 406c1f583fd..17facb4b78f 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
@@ -1703,7 +1703,7 @@ public class GroupMetadataManager {
         } else if (request.memberEpoch() == LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
             throwIfEmptyString(request.memberId(), "MemberId can't be empty.");
             throwIfNull(request.instanceId(), "InstanceId can't be null.");
-        } else {
+        } else if ((request.memberEpoch() <  0) && (request.memberEpoch() != 
LEAVE_GROUP_MEMBER_EPOCH)) {
             throw new InvalidRequestException("MemberEpoch is invalid.");
         }