This is an automated email from the ASF dual-hosted git repository.

jolshan pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 417bd22a06f KAFKA-18163: Move VerificationGuardTest to storage module 
(#18058)
417bd22a06f is described below

commit 417bd22a06f13212ae30ddca496678e946e834c6
Author: Mickael Maison <[email protected]>
AuthorDate: Fri Dec 6 19:18:07 2024 +0100

    KAFKA-18163: Move VerificationGuardTest to storage module (#18058)
    
    Reviewers: Justine Olshan <[email protected]>
---
 .../unit/kafka/log/VerificationGuardTest.scala     | 53 ----------------------
 .../internals/log/VerificationGuardTest.java       | 53 ++++++++++++++++++++++
 2 files changed, 53 insertions(+), 53 deletions(-)

diff --git a/core/src/test/scala/unit/kafka/log/VerificationGuardTest.scala 
b/core/src/test/scala/unit/kafka/log/VerificationGuardTest.scala
deleted file mode 100644
index b18b7430b9a..00000000000
--- a/core/src/test/scala/unit/kafka/log/VerificationGuardTest.scala
+++ /dev/null
@@ -1,53 +0,0 @@
-/**
-  * Licensed to the Apache Software Foundation (ASF) under one or more
-  * contributor license agreements.  See the NOTICE file distributed with
-  * this work for additional information regarding copyright ownership.
-  * The ASF licenses this file to You under the Apache License, Version 2.0
-  * (the "License"); you may not use this file except in compliance with
-  * the License.  You may obtain a copy of the License at
-  *
-  *    http://www.apache.org/licenses/LICENSE-2.0
-  *
-  * Unless required by applicable law or agreed to in writing, software
-  * distributed under the License is distributed on an "AS IS" BASIS,
-  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  * See the License for the specific language governing permissions and
-  * limitations under the License.
-  */
-
-package unit.kafka.log
-
-import org.apache.kafka.storage.internals.log.VerificationGuard
-import org.apache.kafka.storage.internals.log.VerificationGuard.SENTINEL
-import org.junit.jupiter.api.Assertions.{assertEquals, assertFalse, 
assertNotEquals, assertTrue}
-import org.junit.jupiter.api.Test
-
-class VerificationGuardTest {
-
-  @Test
-  def testEqualsAndHashCode(): Unit = {
-    val verificationGuard1 = new VerificationGuard
-    val verificationGuard2 = new VerificationGuard
-
-    assertNotEquals(verificationGuard1, verificationGuard2)
-    assertNotEquals(SENTINEL, verificationGuard1)
-    assertEquals(SENTINEL, SENTINEL)
-
-    assertNotEquals(verificationGuard1.hashCode, verificationGuard2.hashCode)
-    assertNotEquals(SENTINEL.hashCode, verificationGuard1.hashCode)
-    assertEquals(SENTINEL.hashCode, SENTINEL.hashCode)
-  }
-
-  @Test
-  def testVerify(): Unit = {
-    val verificationGuard1 = new VerificationGuard
-    val verificationGuard2 = new VerificationGuard
-
-    assertFalse(verificationGuard1.verify(verificationGuard2))
-    assertFalse(verificationGuard1.verify(SENTINEL))
-    assertFalse(SENTINEL.verify(verificationGuard1))
-    assertFalse(SENTINEL.verify(SENTINEL))
-    assertTrue(verificationGuard1.verify(verificationGuard1))
-  }
-
-}
diff --git 
a/storage/src/test/java/org/apache/kafka/storage/internals/log/VerificationGuardTest.java
 
b/storage/src/test/java/org/apache/kafka/storage/internals/log/VerificationGuardTest.java
new file mode 100644
index 00000000000..d38a541f688
--- /dev/null
+++ 
b/storage/src/test/java/org/apache/kafka/storage/internals/log/VerificationGuardTest.java
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.storage.internals.log;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class VerificationGuardTest {
+
+    @Test
+    public void testEqualsAndHashCode() {
+        VerificationGuard verificationGuard1 = new VerificationGuard();
+        VerificationGuard verificationGuard2 = new VerificationGuard();
+
+        assertNotEquals(verificationGuard1, verificationGuard2);
+        assertNotEquals(VerificationGuard.SENTINEL, verificationGuard1);
+        assertEquals(VerificationGuard.SENTINEL, VerificationGuard.SENTINEL);
+
+        assertNotEquals(verificationGuard1.hashCode(), 
verificationGuard2.hashCode());
+        assertNotEquals(VerificationGuard.SENTINEL.hashCode(), 
verificationGuard1.hashCode());
+        assertEquals(VerificationGuard.SENTINEL.hashCode(), 
VerificationGuard.SENTINEL.hashCode());
+    }
+
+    @Test
+    public void testVerify() {
+        VerificationGuard verificationGuard1 = new VerificationGuard();
+        VerificationGuard verificationGuard2 = new VerificationGuard();
+
+        assertFalse(verificationGuard1.verify(verificationGuard2));
+        assertFalse(verificationGuard1.verify(VerificationGuard.SENTINEL));
+        assertFalse(VerificationGuard.SENTINEL.verify(verificationGuard1));
+        
assertFalse(VerificationGuard.SENTINEL.verify(VerificationGuard.SENTINEL));
+        assertTrue(verificationGuard1.verify(verificationGuard1));
+    }
+}

Reply via email to