(kafka) branch 4.0 updated: KAFKA-18437: Correct version of ShareUpdateRecord value (#18423)

[schofielaj]

This is an automated email from the ASF dual-hosted git repository.

schofielaj pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.0 by this push:
     new 921b7fe7048 KAFKA-18437: Correct version of ShareUpdateRecord value 
(#18423)
921b7fe7048 is described below

commit 921b7fe7048a87c9bc6be2dff988e95f15a1eb41
Author: Andrew Schofield <aschofi...@confluent.io>
AuthorDate: Thu Jan 9 13:46:46 2025 +0000

    KAFKA-18437: Correct version of ShareUpdateRecord value (#18423)
    
    Reviewers: David Jacot <dja...@confluent.io>, Chia-Ping Tsai 
<chia7...@gmail.com>
---
 .../java/org/apache/kafka/coordinator/share/ShareCoordinator.java | 2 +-
 .../kafka/coordinator/share/ShareCoordinatorRecordSerde.java      | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java
 
b/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java
index dd56503dbaf..fc7d83b3cb2 100644
--- 
a/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java
+++ 
b/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java
@@ -35,7 +35,7 @@ public interface ShareCoordinator {
     short SHARE_SNAPSHOT_RECORD_KEY_VERSION = 0;
     short SHARE_SNAPSHOT_RECORD_VALUE_VERSION = 0;
     short SHARE_UPDATE_RECORD_KEY_VERSION = 1;
-    short SHARE_UPDATE_RECORD_VALUE_VERSION = 1;
+    short SHARE_UPDATE_RECORD_VALUE_VERSION = 0;
 
     /**
      * Return the partition index for the given key.
diff --git 
a/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorRecordSerde.java
 
b/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorRecordSerde.java
index a620289d17a..28f59e57d33 100644
--- 
a/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorRecordSerde.java
+++ 
b/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorRecordSerde.java
@@ -29,9 +29,9 @@ public class ShareCoordinatorRecordSerde extends 
CoordinatorRecordSerde {
     @Override
     protected ApiMessage apiMessageKeyFor(short recordVersion) {
         switch (recordVersion) {
-            case ShareCoordinator.SHARE_SNAPSHOT_RECORD_KEY_VERSION:
+            case 0:
                 return new ShareSnapshotKey();
-            case ShareCoordinator.SHARE_UPDATE_RECORD_KEY_VERSION:
+            case 1:
                 return new ShareUpdateKey();
             default:
                 throw new 
CoordinatorLoader.UnknownRecordTypeException(recordVersion);
@@ -41,9 +41,9 @@ public class ShareCoordinatorRecordSerde extends 
CoordinatorRecordSerde {
     @Override
     protected ApiMessage apiMessageValueFor(short recordVersion) {
         switch (recordVersion) {
-            case ShareCoordinator.SHARE_SNAPSHOT_RECORD_VALUE_VERSION:
+            case 0:
                 return new ShareSnapshotValue();
-            case ShareCoordinator.SHARE_UPDATE_RECORD_VALUE_VERSION:
+            case 1:
                 return new ShareUpdateValue();
             default:
                 throw new 
CoordinatorLoader.UnknownRecordTypeException(recordVersion);