This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 7e46087570d MINOR: rename `resendBrokerRegistrationUnlessZkMode` to
`resendBrokerRegistration` (#18645)
7e46087570d is described below
commit 7e46087570d70f42b85fa6f0e23d3b2441591eb4
Author: Ken Huang <[email protected]>
AuthorDate: Fri Jan 24 00:33:05 2025 +0800
MINOR: rename `resendBrokerRegistrationUnlessZkMode` to
`resendBrokerRegistration` (#18645)
Reviewers: Chia-Ping Tsai <[email protected]>
---
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala | 6 +++---
core/src/main/scala/kafka/server/BrokerServer.scala | 2 +-
.../test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
b/core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
index bd01311fedd..3079af0a307 100644
--- a/core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
+++ b/core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
@@ -260,11 +260,11 @@ class BrokerLifecycleManager(
new OfflineDirBrokerFailureEvent(directory))
}
- def resendBrokerRegistrationUnlessZkMode(): Unit = {
- eventQueue.append(new ResendBrokerRegistrationUnlessZkModeEvent())
+ def resendBrokerRegistration(): Unit = {
+ eventQueue.append(new ResendBrokerRegistrationEvent())
}
- private class ResendBrokerRegistrationUnlessZkModeEvent extends
EventQueue.Event {
+ private class ResendBrokerRegistrationEvent extends EventQueue.Event {
override def run(): Unit = {
registered = false
scheduleNextCommunicationImmediately()
diff --git a/core/src/main/scala/kafka/server/BrokerServer.scala
b/core/src/main/scala/kafka/server/BrokerServer.scala
index ace134773ae..3c735be0004 100644
--- a/core/src/main/scala/kafka/server/BrokerServer.scala
+++ b/core/src/main/scala/kafka/server/BrokerServer.scala
@@ -534,7 +534,7 @@ class BrokerServer(
})
metadataPublishers.add(brokerMetadataPublisher)
brokerRegistrationTracker = new
BrokerRegistrationTracker(config.brokerId,
- () => lifecycleManager.resendBrokerRegistrationUnlessZkMode())
+ () => lifecycleManager.resendBrokerRegistration())
metadataPublishers.add(brokerRegistrationTracker)
diff --git
a/core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala
b/core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala
index a7204ffe884..5b621671ad6 100644
--- a/core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala
+++ b/core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala
@@ -288,7 +288,7 @@ class BrokerLifecycleManagerTest {
assertEquals(1000L, manager.brokerEpoch)
// Trigger JBOD MV update
- manager.resendBrokerRegistrationUnlessZkMode()
+ manager.resendBrokerRegistration()
// Accept new registration, response sets epoch to 1200
nextRegistrationRequest(1200L)