This is an automated email from the ASF dual-hosted git repository.

dajac pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.0 by this push:
     new fe258c74efd MINOR: Fix TestBounce sys test (#18798)
fe258c74efd is described below

commit fe258c74efd3cecacc81beb70b5e7c3da942938f
Author: David Jacot <[email protected]>
AuthorDate: Tue Feb 4 14:49:20 2025 +0100

    MINOR: Fix TestBounce sys test (#18798)
    
    ```
    
================================================================================
    SESSION REPORT (ALL TESTS)
    ducktape version: 0.12.0
    session_id:       2025-02-04--005
    run time:         4 minutes 0.023 seconds
    tests run:        4
    passed:           4
    flaky:            0
    failed:           0
    ignored:          0
    
================================================================================
    ```
    
    Reviewers: Lianet Magrans <[email protected]>
---
 tests/kafkatest/sanity_checks/test_bounce.py | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/tests/kafkatest/sanity_checks/test_bounce.py 
b/tests/kafkatest/sanity_checks/test_bounce.py
index fdefc9606f3..1ccd05135d0 100644
--- a/tests/kafkatest/sanity_checks/test_bounce.py
+++ b/tests/kafkatest/sanity_checks/test_bounce.py
@@ -21,8 +21,6 @@ from ducktape.utils.util import wait_until
 
 from kafkatest.services.kafka import KafkaService, quorum
 from kafkatest.services.verifiable_producer import VerifiableProducer
-from kafkatest.services.zookeeper import ZookeeperService
-
 
 class TestBounce(Test):
     """Sanity checks on verifiable producer service class with cluster roll."""
@@ -35,9 +33,8 @@ class TestBounce(Test):
         if quorum_size < 1:
             raise Exception("Illegal %s value provided for the test: %s" % 
(quorum_size_arg_name, quorum_size))
         self.topic = "topic"
-        self.zk = ZookeeperService(test_context, num_nodes=quorum_size) if 
quorum.for_test(test_context) == quorum.zk else None
         num_kafka_nodes = quorum_size if quorum.for_test(test_context) == 
quorum.combined_kraft else 1
-        self.kafka = KafkaService(test_context, num_nodes=num_kafka_nodes, 
zk=self.zk,
+        self.kafka = KafkaService(test_context, num_nodes=num_kafka_nodes, 
zk=None,
                                   topics={self.topic: {"partitions": 1, 
"replication-factor": 1}},
                                   controller_num_nodes_override=quorum_size)
         self.num_messages = 1000
@@ -46,13 +43,10 @@ class TestBounce(Test):
         # This will produce to source kafka cluster
         self.producer = VerifiableProducer(self.test_context, num_nodes=1, 
kafka=self.kafka, topic=self.topic,
                                            max_messages=self.num_messages, 
throughput=self.num_messages // 10)
-    def setUp(self):
-        if self.zk:
-            self.zk.start()
 
-    # ZooKeeper and KRaft, quorum size = 1
+    # Isolated and Combined KRaft, quorum size = 3
     @cluster(num_nodes=4)
-    @matrix(metadata_quorum=quorum.all, quorum_size=[1])
+    @matrix(metadata_quorum=quorum.all_kraft, quorum_size=[1])
     # Isolated and Combined KRaft, quorum size = 3
     @cluster(num_nodes=6)
     @matrix(metadata_quorum=quorum.all_kraft, quorum_size=[3])

Reply via email to