This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 8e3a001bf52 MINOR: disable "processing threads" in 
SmokeTestDriverIntegrationTest (#18773)
8e3a001bf52 is described below

commit 8e3a001bf526020d8b81c36a3e95299d13ccfa38
Author: Matthias J. Sax <[email protected]>
AuthorDate: Tue Feb 4 09:59:14 2025 -0800

    MINOR: disable "processing threads" in SmokeTestDriverIntegrationTest 
(#18773)
    
    Reviewers: Bruno Cadonna <[email protected]>
---
 .../kafka/streams/integration/SmokeTestDriverIntegrationTest.java    | 2 +-
 streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java    | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git 
a/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
 
b/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
index b95e11df4c6..6f072415803 100644
--- 
a/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
+++ 
b/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
@@ -104,7 +104,7 @@ public class SmokeTestDriverIntegrationTest {
     // We set 2 timeout condition to fail the test before passing the 
verification:
     // (1) 10 min timeout, (2) 30 tries of polling without getting any data
     @ParameterizedTest
-    @CsvSource({"false, false", "true, false", "true, true"})
+    @CsvSource({"false, false", "true, false"})
     public void shouldWorkWithRebalance(final boolean stateUpdaterEnabled, 
final boolean processingThreadsEnabled) throws InterruptedException {
         Exit.setExitProcedure((statusCode, message) -> {
             throw new AssertionError("Test called exit(). code:" + statusCode 
+ " message:" + message);
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java 
b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index 1801eeab0a0..af85e63c655 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -1293,6 +1293,11 @@ public class StreamsConfig extends AbstractConfig {
         public static final String PROCESSING_THREADS_ENABLED = 
"__processing.threads.enabled__";
 
         public static boolean processingThreadsEnabled(final Map<String, 
Object> configs) {
+            // note: we did disable testing "processing threads"` in 
SmokeTestDriverIntegrationTest due to
+            // high failure rate, and the feature being incomplete with no 
active work
+            //
+            // we should re-enable testing this feature in 
SmokeTestDriverIntegrationTest
+            // once it is complete (or maybe even earlier when we resumg 
working on it
             return InternalConfig.getBoolean(configs, 
InternalConfig.PROCESSING_THREADS_ENABLED, false);
         }
 

Reply via email to