This is an automated email from the ASF dual-hosted git repository.

dajac pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git

commit 2a9241b85538384f8f13be83b6829512d1bad229
Author: TengYao Chi <[email protected]>
AuthorDate: Sat Feb 22 15:53:34 2025 +0800

    MINOR: Fix fail e2e TestUpgrade#test_combined_mode_upgrade and 
test_isolated_mode_upgrade (#19003)
    
    #18845 assumed a baseline of 3.3 for server protocol versions so that
    the lower version couldn't roll up to 4.0. Hence, the
    `TestUpgrade#test_combined_mode_upgrad` and `test_isolated_mode_upgrade`
    failed for the 3.1 and 3.2 versions.
    
    e2e tests result with this patch on jenkins:
    ![Screenshot from 2025-02-22
    
13-22-17](https://github.com/user-attachments/assets/2de6f707-8281-4f30-b5d0-83dd4de9666d)
    e2e tests result with this patch on local machine:
    ![Screenshot from 2025-02-22
    
13-28-16](https://github.com/user-attachments/assets/2e5e563a-1ac4-4894-ba30-593304697d1d)
    
    Reviewers: David Jacot <[email protected]>
---
 tests/kafkatest/tests/core/upgrade_test.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kafkatest/tests/core/upgrade_test.py 
b/tests/kafkatest/tests/core/upgrade_test.py
index 70b44140768..dd29b7375e4 100644
--- a/tests/kafkatest/tests/core/upgrade_test.py
+++ b/tests/kafkatest/tests/core/upgrade_test.py
@@ -173,13 +173,13 @@ class TestUpgrade(ProduceConsumeValidateTest):
         assert self.kafka.check_protocol_errors(self)
 
     @cluster(num_nodes=5)
-    @matrix(from_kafka_version=[str(LATEST_3_1), str(LATEST_3_2), 
str(LATEST_3_3), str(LATEST_3_4), str(LATEST_3_5), str(LATEST_3_6), 
str(LATEST_3_7), str(LATEST_3_8), str(LATEST_3_9), str(DEV_BRANCH)],
+    @matrix(from_kafka_version=[str(LATEST_3_3), str(LATEST_3_4), 
str(LATEST_3_5), str(LATEST_3_6), str(LATEST_3_7), str(LATEST_3_8), 
str(LATEST_3_9), str(DEV_BRANCH)],
             metadata_quorum=[combined_kraft])
     def test_combined_mode_upgrade(self, from_kafka_version, metadata_quorum, 
use_new_coordinator=False):
         self.run_upgrade(from_kafka_version)
 
     @cluster(num_nodes=8)
-    @matrix(from_kafka_version=[str(LATEST_3_1), str(LATEST_3_2), 
str(LATEST_3_3), str(LATEST_3_4), str(LATEST_3_5), str(LATEST_3_6), 
str(LATEST_3_7), str(LATEST_3_8), str(LATEST_3_9), str(DEV_BRANCH)],
+    @matrix(from_kafka_version=[str(LATEST_3_3), str(LATEST_3_4), 
str(LATEST_3_5), str(LATEST_3_6), str(LATEST_3_7), str(LATEST_3_8), 
str(LATEST_3_9), str(DEV_BRANCH)],
             metadata_quorum=[isolated_kraft])
     def test_isolated_mode_upgrade(self, from_kafka_version, metadata_quorum, 
use_new_coordinator=False):
         self.run_upgrade(from_kafka_version)

Reply via email to