(kafka) branch trunk updated: MINOR: Minor tidying in GroupMetadataManager (#19411)

[schofielaj]

This is an automated email from the ASF dual-hosted git repository.

schofielaj pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new e2d472ddb19 MINOR: Minor tidying in GroupMetadataManager (#19411)
e2d472ddb19 is described below

commit e2d472ddb19be201dee52010b690da90295b33de
Author: Andrew Schofield <aschofi...@confluent.io>
AuthorDate: Tue Apr 8 07:27:02 2025 +0100

    MINOR: Minor tidying in GroupMetadataManager (#19411)
    
    Some trivial tidying up in GroupMetadataManager.
    
    Reviewers: Lianet Magrans <lmagr...@confluent.io>
---
 .../org/apache/kafka/coordinator/group/GroupMetadataManager.java | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
index c1e1fe3760d..08e9159b02d 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
@@ -866,7 +866,7 @@ public class GroupMetadataManager {
      * @param groupId           The group ID.
      *
      * @return A StreamsGroup.
-     * @throws GroupIdNotFoundException if the group does not exist
+     * @throws GroupIdNotFoundException if the group does not exist or is not 
a streams group.
      *
      * Package private for testing.
      */
@@ -1172,8 +1172,8 @@ public class GroupMetadataManager {
      * @param groupId           The group id.
      * @param committedOffset   A specified committed offset corresponding to 
this shard.
      *
-     * @return A ConsumerGroup.
-     * @throws GroupIdNotFoundException if the group does not exist or is not 
a consumer group.
+     * @return A ShareGroup.
+     * @throws GroupIdNotFoundException if the group does not exist or is not 
a share group.
      */
     public ShareGroup shareGroup(
         String groupId,
@@ -1588,7 +1588,7 @@ public class GroupMetadataManager {
             }
         } else if (request.memberEpoch() == LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
             throwIfNull(request.instanceId(), "InstanceId can't be null.");
-        } else if (request.memberEpoch() <  LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
+        } else if (request.memberEpoch() < LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
             throw new InvalidRequestException(String.format("MemberEpoch is 
%d, but must be greater than or equal to -2.",
                 request.memberEpoch()));
         }
@@ -3418,7 +3418,6 @@ public class GroupMetadataManager {
         resolvedRegexes.forEach((__, topicNames) -> 
topicNames.removeAll(deniedTopics));
     }
 
-
     /**
      * Handle the result of the asynchronous tasks which resolves the regular 
expressions.
      *