This is an automated email from the ASF dual-hosted git repository.
frankvicky pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 80b209d2a0c MINOR: remove unused parameter from KafkaMetadataLog
(#19458)
80b209d2a0c is described below
commit 80b209d2a0c6f61ddb165d15070e16c88697d638
Author: Milly <[email protected]>
AuthorDate: Tue Apr 15 10:26:55 2025 +0800
MINOR: remove unused parameter from KafkaMetadataLog (#19458)
1. Remove unused parameter from KafkaMetadataLog.
2. Give Utils.closeQuietly a meaningful name when closing reader.
Reviewers: TengYao Chi <[email protected]>, Ken Huang
<[email protected]>, Jhen-Yung Hsu <[email protected]>, Chia-Ping
Tsai <[email protected]>
---------
Co-authored-by: TengYao Chi <[email protected]>
---
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
b/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
index ebc2f3c81cf..2b7404ef1e7 100644
--- a/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
+++ b/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
@@ -553,7 +553,7 @@ final class KafkaMetadataLog private (
if (expiredSnapshots.nonEmpty) {
scheduler.scheduleOnce(
"delete-snapshot-files",
- () => KafkaMetadataLog.deleteSnapshotFiles(log.dir.toPath,
expiredSnapshots, this),
+ () => KafkaMetadataLog.deleteSnapshotFiles(log.dir.toPath,
expiredSnapshots),
config.deleteDelayMillis
)
}
@@ -698,12 +698,10 @@ object KafkaMetadataLog extends Logging {
private def deleteSnapshotFiles(
logDir: Path,
- expiredSnapshots: mutable.TreeMap[OffsetAndEpoch,
Option[FileRawSnapshotReader]],
- logging: Logging
- ): Unit = {
+ expiredSnapshots: mutable.TreeMap[OffsetAndEpoch,
Option[FileRawSnapshotReader]]): Unit = {
expiredSnapshots.foreach { case (snapshotId, snapshotReader) =>
snapshotReader.foreach { reader =>
- Utils.closeQuietly(reader, "reader")
+ Utils.closeQuietly(reader, "FileRawSnapshotReader")
}
Snapshots.deleteIfExists(logDir, snapshotId)
}
