This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new bc797b077f1 KAFKA-19314 Remove unnecessary code of closing 
snapshotWriter (#19763)
bc797b077f1 is described below

commit bc797b077f1843d93a16028b25a5f9839cfb2c85
Author: Jing-Jia Hung <32607481+jingji...@users.noreply.github.com>
AuthorDate: Fri May 23 03:57:14 2025 +0800

    KAFKA-19314 Remove unnecessary code of closing snapshotWriter (#19763)
    
    - Remove redundant close of `snapshotWriter`.
    - `snapshotWriter` is already closed by `RaftSnapshotWriter#writer`.
    
    Reviewers: Jhen-Yung Hsu <jhenyung...@gmail.com>, Ken Huang
     <s7133...@gmail.com>, Chia-Ping Tsai <chia7...@gmail.com>
---
 .../src/main/java/org/apache/kafka/image/publisher/SnapshotEmitter.java  | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/metadata/src/main/java/org/apache/kafka/image/publisher/SnapshotEmitter.java 
b/metadata/src/main/java/org/apache/kafka/image/publisher/SnapshotEmitter.java
index 398e3fdae8a..cb025823bf4 100644
--- 
a/metadata/src/main/java/org/apache/kafka/image/publisher/SnapshotEmitter.java
+++ 
b/metadata/src/main/java/org/apache/kafka/image/publisher/SnapshotEmitter.java
@@ -158,7 +158,6 @@ public class SnapshotEmitter implements 
SnapshotGenerator.Emitter {
             throw e;
         } finally {
             Utils.closeQuietly(writer, "RaftSnapshotWriter");
-            Utils.closeQuietly(snapshotWriter.get(), "SnapshotWriter");
         }
     }
 }

Reply via email to