(kafka) branch trunk updated: MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits (#19837)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new a83bfda39bb MINOR: Fix typo to actually use rocksdb 
setOptimizeFiltersForHits (#19837)
a83bfda39bb is described below

commit a83bfda39bbec46b134f5ab8093e590665a282a0
Author: Chuckame <chuck...@users.noreply.github.com>
AuthorDate: Sun Jun 15 18:18:29 2025 +0200

    MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits (#19837)
    
    This PR fixes a typo in the `RocksDBStore` where it currently uses a
    getter named `optimizeFiltersForHits`. However, to set the flag to true,
    we have to use `setOptimizeFiltersForHits(true)` instead.
    
    Reviewers: Matthias J. Sax <matth...@confluent.io>, Chia-Ping Tsai
     <chia7...@gmail.com>
---
 .../java/org/apache/kafka/streams/state/internals/RocksDBStore.java     | 2 +-
 .../java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
 
b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
index 6457a2c8fab..ede618237cf 100644
--- 
a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
+++ 
b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
@@ -195,7 +195,7 @@ public class RocksDBStore implements KeyValueStore<Bytes, 
byte[]>, BatchWritingS
         filter = new BloomFilter();
         tableConfig.setFilterPolicy(filter);
 
-        userSpecifiedOptions.optimizeFiltersForHits();
+        userSpecifiedOptions.setOptimizeFiltersForHits(true);
         userSpecifiedOptions.setTableFormatConfig(tableConfig);
         userSpecifiedOptions.setWriteBufferSize(WRITE_BUFFER_SIZE);
         userSpecifiedOptions.setCompressionType(COMPRESSION_TYPE);
diff --git 
a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
 
b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
index 8a02289890e..70224c8013c 100644
--- 
a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
+++ 
b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
@@ -1256,7 +1256,7 @@ public class RocksDBStoreTest extends 
AbstractKeyValueStoreTest {
             if (enableBloomFilters) {
                 filter = new BloomFilter();
                 tableConfig.setFilterPolicy(filter);
-                options.optimizeFiltersForHits();
+                options.setOptimizeFiltersForHits(true);
                 bloomFiltersSet = true;
             } else {
                 options.setOptimizeFiltersForHits(false);