This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 0202721b4c1 MINOR: Cleanups in jmh-benchmarks module (#20374)
0202721b4c1 is described below
commit 0202721b4c175c606c3d079e602fe33e8faea018
Author: Sanskar Jhajharia <sjhajha...@confluent.io>
AuthorDate: Wed Aug 20 19:50:54 2025 +0530
MINOR: Cleanups in jmh-benchmarks module (#20374)
This PR aims at cleaning up the `jmh-benchmarks` module further by
getting rid of some extra code which can be replaced by record
Reviewers: Ken Huang <s7133...@gmail.com>, Chia-Ping Tsai
<chia7...@gmail.com>
---
.../assignor/StreamsStickyAssignorBenchmark.java | 5 ++--
.../kafka/jmh/core/TestPurgatoryPerformance.java | 30 ++--------------------
2 files changed, 4 insertions(+), 31 deletions(-)
diff --git
a/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/StreamsStickyAssignorBenchmark.java
b/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/StreamsStickyAssignorBenchmark.java
index 3293c0223f2..22863fef5fa 100644
---
a/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/StreamsStickyAssignorBenchmark.java
+++
b/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/StreamsStickyAssignorBenchmark.java
@@ -44,7 +44,6 @@ import org.openjdk.jmh.annotations.Threads;
import org.openjdk.jmh.annotations.Warmup;
import org.openjdk.jmh.infra.Blackhole;
-import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -107,7 +106,7 @@ public class StreamsStickyAssignorBenchmark {
taskAssignor = new StickyTaskAssignor();
Map<String, StreamsGroupMember> members = createMembers();
- this.assignmentConfigs = Collections.singletonMap(
+ this.assignmentConfigs = Map.of(
"num.standby.replicas",
Integer.toString(standbyReplicas)
);
@@ -138,7 +137,7 @@ public class StreamsStickyAssignorBenchmark {
for (Map.Entry<String, AssignmentMemberSpec> member :
groupSpec.members().entrySet()) {
MemberAssignment memberAssignment = members.getOrDefault(
member.getKey(),
- new MemberAssignment(Collections.emptyMap(),
Collections.emptyMap(), Collections.emptyMap())
+ new MemberAssignment(Map.of(), Map.of(), Map.of())
);
updatedMemberSpec.put(member.getKey(), new AssignmentMemberSpec(
diff --git
a/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java
b/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java
index 68f3a52918c..e0fd3d8c8d4 100644
---
a/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java
+++
b/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java
@@ -30,7 +30,6 @@ import java.lang.reflect.InvocationTargetException;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
-import java.util.Objects;
import java.util.Optional;
import java.util.Random;
import java.util.concurrent.CountDownLatch;
@@ -405,12 +404,7 @@ public class TestPurgatoryPerformance {
}
- private static class Scheduled implements Delayed {
- final FakeOperation operation;
-
- public Scheduled(FakeOperation operation) {
- this.operation = operation;
- }
+ private record Scheduled(FakeOperation operation) implements Delayed {
@Override
public long getDelay(TimeUnit unit) {
@@ -429,30 +423,11 @@ public class TestPurgatoryPerformance {
}
}
- private static class FakeOperationKey implements DelayedOperationKey {
- private final String key;
-
- public FakeOperationKey(String key) {
- this.key = key;
- }
-
+ private record FakeOperationKey(String key) implements DelayedOperationKey
{
@Override
public String keyLabel() {
return key;
}
-
- @Override
- public boolean equals(Object o) {
- if (this == o) return true;
- if (o == null || getClass() != o.getClass()) return false;
- FakeOperationKey that = (FakeOperationKey) o;
- return Objects.equals(key, that.key);
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(key);
- }
}
private static class FakeOperation extends DelayedOperation {
@@ -469,7 +444,6 @@ public class TestPurgatoryPerformance {
@Override
public void onExpiration() {
-
}
@Override
